Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1971763002: Revert "Adjusts dart2js SSA builder to tolerate method type arguments." (Closed)

Created:
4 years, 7 months ago by eernst
Modified:
4 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Adjusts dart2js SSA builder to tolerate method type arguments." This reverts commit ee926fac8dd4fbc1b1cec9c8e836be916baf81b1. Also revert "Removed generic method tests from status file.", commit fa48b7e17ba79038c465270f40d2b6caa9cae954. Committed: https://github.com/dart-lang/sdk/commit/a76745e18f1ed22a383aa778be087833275776c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -34 lines) Patch
M pkg/compiler/lib/src/dart_types.dart View 2 chunks +0 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
TBR: Reverting 1969753002 and 1966233002.
4 years, 7 months ago (2016-05-11 14:14:16 UTC) #2
eernst
Committed patchset #1 (id:1) manually as a76745e18f1ed22a383aa778be087833275776c0 (presubmit successful).
4 years, 7 months ago (2016-05-11 14:15:14 UTC) #4
Johnni Winther
4 years, 7 months ago (2016-05-11 14:24:52 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698