Issue 197173002: Revert "Implement PersistentValueMap, a map that stores UniquePersistent values."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197173002: Revert "Implement PersistentValueMap, a map that stores UniquePersistent values." (Closed)

Created:
6 years, 9 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 9 months ago

Reviewers:
dcarney, vogelheim

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Implement PersistentValueMap, a map that stores UniquePersistent values." and "Win64 fix for r19833." This reverts commits r19833 and r19837 for breaking Windows tests (test-api/PersistentValueMap). TBR=vogelheim@chromium.org,dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19839

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -313 lines)			Patch
M	include/v8.h	View	12 chunks	+5 lines, -196 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/global-handles.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/global-handles.cc	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+0 lines, -109 lines	0 comments	Download

Total messages: 2 (0 generated)

Dmitry Lomov (no reviews)

6 years, 9 months ago (2014-03-12 11:40:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r19839 (tree was closed).