Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19717004: [NaCl SDK] Add nacl_io and sdk_util namespaces. (Closed)

Created:
7 years, 5 months ago by binji
Modified:
7 years, 5 months ago
Reviewers:
noelallen1
CC:
chromium-reviews, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Add nacl_io and sdk_util namespaces. BUG=none R=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212906

Patch Set 1 #

Patch Set 2 : added namespace for sdk_util #

Patch Set 3 : fix bad copyright in mount_mem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -47 lines) Patch
M native_client_sdk/src/examples/demo/earth/earth.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/examples/demo/voronoi/voronoi.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/error.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/inode_pool.h View 2 chunks +4 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_handle.h View 2 chunks +11 lines, -7 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_handle.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_intercept.cc View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_object.h View 2 chunks +6 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_object.cc View 3 chunks +5 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount.h View 2 chunks +6 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_dev.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_dev.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_factory.h View 2 chunks +5 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_html5fs.h View 2 chunks +5 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_html5fs.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_http.h View 2 chunks +7 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_http.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_mem.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_mem.cc View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node.h View 3 chunks +7 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_dir.h View 3 chunks +4 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_dir.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_http.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_http.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_mem.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_mem.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_passthrough.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_passthrough.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/path.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/path.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper_interface.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper_interface.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/real_pepper_interface.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/real_pepper_interface.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/typed_mount_factory.h View 2 chunks +6 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/kernel_object_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/kernel_proxy_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/kernel_proxy_test.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/kernel_wrap_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_html5fs_test.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_http_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_mock.h View 1 chunk +7 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_node_mock.h View 1 chunk +5 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_node_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_node_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/path_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/pepper_interface_mock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/ps_instance.h View 2 chunks +1 line, -4 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/atomicops.h View 1 4 chunks +10 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/auto_lock.h View 2 chunks +4 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/sdk_util/ref_object.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/scoped_ref.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/simple_lock.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/thread_pool.h View 2 chunks +5 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/thread_pool.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/thread_safe_queue.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
binji
7 years, 5 months ago (2013-07-18 16:00:12 UTC) #1
noelallen1
lgtm
7 years, 5 months ago (2013-07-19 22:09:49 UTC) #2
binji
7 years, 5 months ago (2013-07-22 17:40:03 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r212906 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698