[debugger] Refactor LiveEdit function info collection

src/debug/liveedit.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_DEBUG_LIVEEDIT_H_
 #define V8_DEBUG_LIVEEDIT_H_
 
 
 // Live Edit feature implementation.
 // User should be able to change script on already running VM. This feature
@@ skipping 14 matching lines @@
 // instantiate newly compiled functions.
 
 
 #include "src/allocation.h"
 #include "src/compiler.h"
 
 namespace v8 {
 namespace internal {
 
 // This class collects some specific information on structure of functions
-// in a particular script. It gets called from compiler all the time, but
-// actually records any data only when liveedit operation is in process;
-// in any other time this class is very cheap.
+// in a particular script.
 //
 // The primary interest of the Tracker is to record function scope structures
-// in order to analyze whether function code maybe safely patched (with new
+// in order to analyze whether function code may be safely patched (with new
 // code successfully reading existing data from function scopes). The Tracker
 // also collects compiled function codes.
-class LiveEditFunctionTracker {
+class LiveEditFunctionTracker : AllStatic {

[Yang, 2016/05/11 07:29:09]

As previously described, we should merge the functionality of this and
FunctionInfoListener into LiveEditFunctionVisitor.

[jgruber1, 2016/05/12 12:30:25]

Done.

  public:
-  explicit LiveEditFunctionTracker(Isolate* isolate, FunctionLiteral* fun);
-  ~LiveEditFunctionTracker();
-  void RecordFunctionInfo(Handle<SharedFunctionInfo> info,
-                          FunctionLiteral* lit, Zone* zone);
+  static void Collect(Handle<Script> script, ParseInfo* parse_info,
+                      Isolate* isolate);
 
   static bool IsActive(Isolate* isolate);
-
- private:
-  Isolate* isolate_;
 };
 
 
 class LiveEdit : AllStatic {
  public:
   // Describes how exactly a frame has been dropped from stack.
   enum FrameDropMode {
     // No frame has been dropped.
     FRAMES_UNTOUCHED,
     // The top JS frame had been calling debug break slot stub. Patch the
@@ skipping 292 matching lines @@
   static const int kSharedInfoOffset_ = 3;
   static const int kSize_ = 4;
 
   friend class JSArrayBasedStruct<SharedInfoWrapper>;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif /* V8_DEBUG_LIVEEDIT_H_ */