Fix build/mac_toolchain.py for pylint warning.

Fix build/mac_toolchain.py for pylint warning.

* Erase unused variable and unused argument.
* Specify exception type.

BUG=

Committed: https://crrev.com/1a1610f152f2912df8ed06ce576672b55684b215
Cr-Commit-Position: refs/heads/master@{#393785}

[tikuta, 2016-05-11 05:47:47]

Description was changed from

==========
fix to supress pylint.

BUG=
==========

to

==========
fix for pylint warning.

BUG=
==========

[tikuta, 2016-05-11 05:49:46]

tikuta@chromium.org changed reviewers:
+ justincohen@chromium.org

[justincohen, 2016-05-11 13:52:21]

Oops.  Is there a bot that runs pylint to catch this, or did you run it
yourself?  thanks!

https://codereview.chromium.org/1971663002/diff/1/build/mac_toolchain.py
File build/mac_toolchain.py (left):

https://codereview.chromium.org/1971663002/diff/1/build/mac_toolchain.py#oldc...
build/mac_toolchain.py:112: def AcceptLicense(directory):
and remove this.

https://codereview.chromium.org/1971663002/diff/1/build/mac_toolchain.py
File build/mac_toolchain.py (right):

https://codereview.chromium.org/1971663002/diff/1/build/mac_toolchain.py#newc...
build/mac_toolchain.py:179: AcceptLicense(TOOLCHAIN_BUILD_DIR)
probably makes more sense to remove the param.

https://codereview.chromium.org/1971663002/diff/1/build/mac_toolchain.py#newc...
build/mac_toolchain.py:197: AcceptLicense(TOOLCHAIN_BUILD_DIR)
and here

[tikuta, 2016-05-12 01:48:17]

Thanks for your review.

On 2016/05/11 13:52:21, justincohen wrote:
> Oops.  Is there a bot that runs pylint to catch this, or did you run it
> yourself?  thanks!
We use this script in our project goma.
pylint is used in our repository.


>
https://codereview.chromium.org/1971663002/diff/1/build/mac_toolchain.py#newc...
> build/mac_toolchain.py:179: AcceptLicense(TOOLCHAIN_BUILD_DIR)
> probably makes more sense to remove the param.
Done

>
https://codereview.chromium.org/1971663002/diff/1/build/mac_toolchain.py#newc...
> build/mac_toolchain.py:197: AcceptLicense(TOOLCHAIN_BUILD_DIR)
> and here
Done

[tikuta, 2016-05-12 02:02:34]

https://codereview.chromium.org/1971663002/diff/1/build/mac_toolchain.py
File build/mac_toolchain.py (right):

https://codereview.chromium.org/1971663002/diff/1/build/mac_toolchain.py#newc...
build/mac_toolchain.py:179: AcceptLicense(TOOLCHAIN_BUILD_DIR)
On 2016/05/11 13:52:21, justincohen wrote:
> probably makes more sense to remove the param.

Done.

https://codereview.chromium.org/1971663002/diff/1/build/mac_toolchain.py#newc...
build/mac_toolchain.py:197: AcceptLicense(TOOLCHAIN_BUILD_DIR)
On 2016/05/11 13:52:21, justincohen wrote:
> and here

Done.

[justincohen, 2016-05-12 13:27:37]

thanks, lgtm!

[justincohen, 2016-05-12 13:29:08]

Please update the subject to be more specific.  Is there a bot or tool that
found this?

[tikuta, 2016-05-13 02:43:15]

Description was changed from

==========
fix for pylint warning.

BUG=
==========

to

==========
* pylint is used in internal project goma.
  In goma, git cl upload runs pylint and warning was detected.

BUG=
==========

[tikuta, 2016-05-13 02:44:57]

tikuta@chromium.org changed reviewers:
+ shinyak@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org

[tikuta, 2016-05-13 02:45:57]

On 2016/05/12 13:29:08, justincohen wrote:
> Please update the subject to be more specific.  Is there a bot or tool that
> found this?

Thank you lgtm.
the subject is updated.

[tikuta, 2016-05-13 04:18:56]

Description was changed from

==========
* pylint is used in internal project goma.
  In goma, git cl upload runs pylint and warning was detected.

BUG=
==========

to

==========
* erase unused variable and unused argument
* specify exception type

BUG=
==========

[Yoshisato Yanagisawa, 2016-05-13 04:37:09]

On 2016/05/13 02:45:57, tikuta wrote:
> On 2016/05/12 13:29:08, justincohen wrote:
> > Please update the subject to be more specific.  Is there a bot or tool that
> > found this?

Sorry for jumping in.
Our project borrows several code from chromium, and our PRESUBMIT check found
imported code has pylint warnings.

Do you know why chromium does not run pylint in PRESUBMIT?

[Yoshisato Yanagisawa, 2016-05-13 04:37:25]

Description was changed from

==========
* erase unused variable and unused argument
* specify exception type

BUG=
==========

to

==========
fix build/mac_toolchain.py for pylint warning

* erase unused variable and unused argument
* specify exception type

BUG=
==========

[Yoshisato Yanagisawa, 2016-05-13 04:41:21]

lgtm

FYI, I have copied the subject to the first line of the description because, as
far as I understand, only description is shown to commit message.

[ukai, 2016-05-13 07:05:19]

lgtm

note:

% ~/depot_tools/pylint build/mac_toolchain.py 
************* Module mac_toolchain
W:104,18: Unused argument 'directory' (unused-argument)
W:163, 2: No exception type(s) specified (bare-except)

[justincohen, 2016-05-13 15:41:49]

I'm not sure, I'll ask around.

[justincohen, 2016-05-13 15:42:08]

Description was changed from

==========
fix build/mac_toolchain.py for pylint warning

* erase unused variable and unused argument
* specify exception type

BUG=
==========

to

==========
Fix build/mac_toolchain.py for pylint warning.

* Erase unused variable and unused argument.
* Specify exception type.

BUG=
==========

[tikuta, 2016-05-16 01:48:39]

The CQ bit was checked by tikuta@chromium.org

[tikuta, 2016-05-16 01:48:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
justincohen@chromium.org
Link to the patchset: https://codereview.chromium.org/1971663002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-16 01:48:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971663002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971663002/40001

[commit-bot: I haz the power, 2016-05-16 02:28:21]

Description was changed from

==========
Fix build/mac_toolchain.py for pylint warning.

* Erase unused variable and unused argument.
* Specify exception type.

BUG=
==========

to

==========
Fix build/mac_toolchain.py for pylint warning.

* Erase unused variable and unused argument.
* Specify exception type.

BUG=
==========

[commit-bot: I haz the power, 2016-05-16 02:28:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-16 02:30:30]

Description was changed from

==========
Fix build/mac_toolchain.py for pylint warning.

* Erase unused variable and unused argument.
* Specify exception type.

BUG=
==========

to

==========
Fix build/mac_toolchain.py for pylint warning.

* Erase unused variable and unused argument.
* Specify exception type.

BUG=

Committed: https://crrev.com/1a1610f152f2912df8ed06ce576672b55684b215
Cr-Commit-Position: refs/heads/master@{#393785}
==========

[commit-bot: I haz the power, 2016-05-16 02:30:32]

Patchset 3 (id:??) landed as
https://crrev.com/1a1610f152f2912df8ed06ce576672b55684b215
Cr-Commit-Position: refs/heads/master@{#393785}