[Cronet] Change sample app to save netlog to app's files directory

[Cronet] Change sample app to save netlog to app's files directory

Previously it saved to the external storage directory which
doesn't work without changes in Android Marshmallow.
I proposed addressing this in http://crrev.com/1961943003
but it greatly complicated the sample app and saving a netlog,
potentially containing private data, into a directory visible by
all apps shouldn't be encouraged.

BUG=610174
R=xunjieli

Committed: https://crrev.com/6f4a1e97c63ae7307010f1059948f1ffb4bb8cba
Cr-Commit-Position: refs/heads/master@{#392918}

[pauljensen, 2016-05-11 02:08:00]

Helen, PTAL.  I decided not to include the discussion of external storage being
unsafe; I figured there's plenty of unsafe things developers code do at every
line of a program that aren't worth discussing.

[xunjieli, 2016-05-11 13:39:29]

lgtm. thanks!

https://codereview.chromium.org/1971643002/diff/1/components/cronet/android/s...
File
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
(right):

https://codereview.chromium.org/1971643002/diff/1/components/cronet/android/s...
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:179:
mCronetEngine.startNetLogToFile(getFilesDir().getPath() + "/netlog.json",
false);
An alternative is to use getCacheDir(), so the system or the user can clear it
if it ends up being too big in memory. getCacheDir() seems to be what cronet
consumers are using.

[pauljensen, 2016-05-11 13:50:28]

https://codereview.chromium.org/1971643002/diff/1/components/cronet/android/s...
File
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
(right):

https://codereview.chromium.org/1971643002/diff/1/components/cronet/android/s...
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:179:
mCronetEngine.startNetLogToFile(getFilesDir().getPath() + "/netlog.json",
false);
On 2016/05/11 13:39:29, xunjieli wrote:
> An alternative is to use getCacheDir(), so the system or the user can clear it
> if it ends up being too big in memory. getCacheDir() seems to be what cronet
> consumers are using.

Done.

[pauljensen, 2016-05-11 13:50:32]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2016-05-11 13:50:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/1971643002/#ps20001
(title: "switch to cache")

[commit-bot: I haz the power, 2016-05-11 13:50:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971643002/20001

[commit-bot: I haz the power, 2016-05-11 14:36:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-11 14:38:00]

Description was changed from

==========
[Cronet] Change sample app to save netlog to app's files directory

Previously it saved to the external storage directory which
doesn't work without changes in Android Marshmallow.
I proposed addressing this in http://crrev.com/1961943003
but it greatly complicated the sample app and saving a netlog,
potentially containing private data, into a directory visible by
all apps shouldn't be encouraged.

BUG=610174
R=xunjieli
==========

to

==========
[Cronet] Change sample app to save netlog to app's files directory

Previously it saved to the external storage directory which
doesn't work without changes in Android Marshmallow.
I proposed addressing this in http://crrev.com/1961943003
but it greatly complicated the sample app and saving a netlog,
potentially containing private data, into a directory visible by
all apps shouldn't be encouraged.

BUG=610174
R=xunjieli

Committed: https://crrev.com/6f4a1e97c63ae7307010f1059948f1ffb4bb8cba
Cr-Commit-Position: refs/heads/master@{#392918}
==========

[commit-bot: I haz the power, 2016-05-11 14:38:01]

Patchset 2 (id:??) landed as
https://crrev.com/6f4a1e97c63ae7307010f1059948f1ffb4bb8cba
Cr-Commit-Position: refs/heads/master@{#392918}