Add isEmpty() query to GrShape and improve comments.

Add isEmpty() query to GrShape and improve comments.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971613004

Committed: https://skia.googlesource.com/skia/+/7c73a53894927d222d4aceed96893daae8ea14f1

[bsalomon, 2016-05-11 19:32:58]

Description was changed from

==========
Add isEmpty() query to GrShape and improve comments.
==========

to

==========
Add isEmpty() query to GrShape and improve comments.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-05-11 19:34:13]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-05-11 21:38:40]

lgtm

https://codereview.chromium.org/1971613004/diff/1/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/1971613004/diff/1/tests/GrShapeTest.cpp#newco...
tests/GrShapeTest.cpp:91: fAppliedPE.asPath(&path);
Couldn't we have a PE for which this isn't true?
Is that worthwhile to test?

[bsalomon, 2016-05-11 21:47:49]

https://codereview.chromium.org/1971613004/diff/1/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/1971613004/diff/1/tests/GrShapeTest.cpp#newco...
tests/GrShapeTest.cpp:91: fAppliedPE.asPath(&path);
On 2016/05/11 21:38:40, robertphillips wrote:
> Couldn't we have a PE for which this isn't true?
> Is that worthwhile to test?

This is asserting that after applying the PE the emptiness of the applied-shape
must agree with the emptiness of the path the applied-shape returns (not the
original).

There is a path effect in this file that turns empty shapes into non-empty
shapes but it isn't applied to the empty shape. I'll make a follow up CL that
does that.

[bsalomon, 2016-05-11 21:47:54]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-05-11 21:48:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971613004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971613004/1

[commit-bot: I haz the power, 2016-05-11 22:15:59]

Description was changed from

==========
Add isEmpty() query to GrShape and improve comments.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add isEmpty() query to GrShape and improve comments.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7c73a53894927d222d4aceed96893daae8ea14f1
==========

[commit-bot: I haz the power, 2016-05-11 22:16:01]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7c73a53894927d222d4aceed96893daae8ea14f1