Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1971613002: Abstract out connection information into ConnectionContext. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Abstract out connection information into ConnectionContext. This is part of my plan to get rid of ApplicationConnection, which serves two roles: as the holder of connection information *and* as the ServiceProvider impl (via ServiceRegistry). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a3a85dcebaa47d2c5e0cf5f5966a4590368de5ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -12 lines) Patch
M mojo/public/cpp/application/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/cpp/application/connection_context.h View 1 chunk +59 lines, -0 lines 0 comments Download
M mojo/public/cpp/application/lib/application_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download
M mojo/public/cpp/application/lib/service_registry.h View 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/public/cpp/application/lib/service_registry.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-11 00:25:14 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-11 00:41:04 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-11 16:18:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3a85dcebaa47d2c5e0cf5f5966a4590368de5ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698