Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1971603003: Revert of Reland: Test dismissing CVC prompt for PaymentRequest (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
Reviewers:
jbudorick, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Test dismissing CVC prompt for PaymentRequest (patchset #1 id:1 of https://codereview.chromium.org/1964243002/ ) Reason for revert: Fails on Android GN with Strict Mode violation. https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/34219 Original issue's description: > Reland: Test dismissing CVC prompt for PaymentRequest > > This is an integration test for PaymentRequest that performs the > following steps: > 1) Launch PaymentRequest UI. > 2) Click "Pay" in PaymentRequest UI. > 3) Click "Cancel" in CVC prompt. > 4) Click "OK" to dismiss the result dialog. > > Originally landed in: > https://crrev.com/ae3e707b1e771518538a8f12de5cdf88e0aef865 > > Consequently reverted in: > https://crrev.com/ce49849aadf7c4378c99cc4da45b3ff7671cdde8 > due to a StrictMode violation. > > Investigations into StrictMode errors seems to point to unclosed Mojo > pipe on shutdown. As a result, this patch adds explicit Mojo pipe > closing to the Java implementation of PaymentRequest service. > > BUG=608223 > > Committed: https://crrev.com/e3aede8b82bc67aa19bd567a35a90c058f23cb6e > Cr-Commit-Position: refs/heads/master@{#392789} TBR=dfalcantara@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608223 Committed: https://crrev.com/6982fd4a1d9a76f7a9cd3f3fc8a053a699b1d21a Cr-Commit-Position: refs/heads/master@{#392837}

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
please use gerrit instead
Created Revert of Reland: Test dismissing CVC prompt for PaymentRequest
4 years, 7 months ago (2016-05-11 02:52:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971603003/1
4 years, 7 months ago (2016-05-11 02:53:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 02:53:52 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6982fd4a1d9a76f7a9cd3f3fc8a053a699b1d21a Cr-Commit-Position: refs/heads/master@{#392837}
4 years, 7 months ago (2016-05-11 02:55:11 UTC) #6
jbudorick
note that this also showed up on two of the stable bots on chromium.android: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/4518 ...
4 years, 7 months ago (2016-05-11 04:03:56 UTC) #8
jbudorick
4 years, 7 months ago (2016-05-11 04:04:49 UTC) #9
Message was sent while issue was closed.
On 2016/05/11 04:03:56, jbudorick wrote:
> note that this also showed up on two of the stable bots on chromium.android:
> 

let's try that again with public links

https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tes...
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Te...

Powered by Google App Engine
This is Rietveld 408576698