appengine/logdog/coordinator/hierarchy/hierarchy_test.go - Issue 1971493003: LogDog: Project READ access for user endpoints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/logdog/coordinator/hierarchy/hierarchy_test.go

Issue 1971493003: LogDog: Project READ access for user endpoints. (Closed) Base URL: https://github.com/luci/luci-go@logdog-project-service-config

Patch Set: Updated patchset dependency Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/logdog/coordinator/endpoints/services/registerStream.go ('K') | « appengine/logdog/coordinator/endpoints/services/terminateStream_test.go ('k') | appengine/logdog/coordinator/hierarchy/project.go » ('j') | appengine/logdog/coordinator/project.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/logdog/coordinator/hierarchy/hierarchy_test.go

diff --git a/appengine/logdog/coordinator/hierarchy/hierarchy_test.go b/appengine/logdog/coordinator/hierarchy/hierarchy_test.go

index 23a15a145f450e3b4af2afa857f32bab21f6023f..1beae99673fef7a3f00366be230f31d4fdd7fe7f 100644

--- a/appengine/logdog/coordinator/hierarchy/hierarchy_test.go

+++ b/appengine/logdog/coordinator/hierarchy/hierarchy_test.go

@@ -11,7 +11,6 @@ import (

ds "github.com/luci/gae/service/datastore"

"github.com/luci/gae/service/info"

"github.com/luci/luci-go/appengine/logdog/coordinator"

- "github.com/luci/luci-go/appengine/logdog/coordinator/config"

ct "github.com/luci/luci-go/appengine/logdog/coordinator/coordinatorTest"

luciConfig "github.com/luci/luci-go/common/config"

"github.com/luci/luci-go/common/logdog/types"

@@ -122,7 +121,7 @@ func TestHierarchy(t *testing.T) {

r.Project = "proj-exclusive"

_, err := Get(c, r)

- So(err, ShouldEqual, config.ErrNoAccess)

+ So(coordinator.IsMembershipError(err), ShouldBeTrue)

})

Convey(`Get will return nothing when no components are registered.`, func() {