appengine/logdog/coordinator/endpoints/services/service.go - Issue 1971493003: LogDog: Project READ access for user endpoints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/logdog/coordinator/endpoints/services/service.go

Issue 1971493003: LogDog: Project READ access for user endpoints. (Closed) Base URL: https://github.com/luci/luci-go@logdog-project-service-config

Patch Set: Updated patchset dependency Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/logdog/coordinator/endpoints/services/registerStream.go ('K') | « appengine/logdog/coordinator/endpoints/services/registerStream_test.go ('k') | appengine/logdog/coordinator/endpoints/services/terminateStream.go » ('j') | appengine/logdog/coordinator/project.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/logdog/coordinator/endpoints/services/service.go

diff --git a/appengine/logdog/coordinator/endpoints/services/service.go b/appengine/logdog/coordinator/endpoints/services/service.go

index 299cc4863c532a01d78365bb8c3c310520ef20d7..1b155da3a892cbc0d96329c33124355ec267e65a 100644

--- a/appengine/logdog/coordinator/endpoints/services/service.go

+++ b/appengine/logdog/coordinator/endpoints/services/service.go

@@ -41,7 +41,11 @@ func New() logdog.ServicesServer {

// We use a type switch here because this is a shared decorator.

if pbm, ok := req.(endpoints.ProjectBoundMessage); ok {

- if err := coordinator.WithProjectNamespaceNoAuth(&c, config.ProjectName(pbm.GetMessageProject())); err != nil {

+ project := config.ProjectName(pbm.GetMessageProject())

+ log.Fields{

+ "project": project,

+ }.Debugf(c, "Request is entering project namespace.")

+ if err := coordinator.WithProjectNamespaceNoAuth(&c, project); err != nil {

return nil, grpcutil.Internal

}