appengine/logdog/coordinator/endpoints/logs/query_test.go - Issue 1971493003: LogDog: Project READ access for user endpoints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/logdog/coordinator/endpoints/logs/query_test.go

Issue 1971493003: LogDog: Project READ access for user endpoints. (Closed) Base URL: https://github.com/luci/luci-go@logdog-project-service-config

Patch Set: Updated patchset dependency Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/logdog/coordinator/context.go ('K') | « appengine/logdog/coordinator/endpoints/logs/list_test.go ('k') | appengine/logdog/coordinator/endpoints/logs/service.go » ('j') | appengine/logdog/coordinator/endpoints/services/registerStream.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/logdog/coordinator/endpoints/logs/query_test.go

diff --git a/appengine/logdog/coordinator/endpoints/logs/query_test.go b/appengine/logdog/coordinator/endpoints/logs/query_test.go

index 06158f715fc55855eb64a4b5b1c536a25dda922a..f66f1297e3b5f1aeda7c67c0174400c5e7eb55ec 100644

--- a/appengine/logdog/coordinator/endpoints/logs/query_test.go

+++ b/appengine/logdog/coordinator/endpoints/logs/query_test.go

@@ -169,14 +169,14 @@ func TestQuery(t *testing.T) {

req.Project = "does-not-exist"

_, err := svr.Query(c, &req)

- So(err, ShouldBeRPCNotFound)

+ So(err, ShouldBeRPCPermissionDenied)

})

- Convey(`An empty query to a project without access fails with NotFound.`, func() {

+ Convey(`An empty query to a project without access fails with PermissionDenied.`, func() {

req.Project = "proj-exclusive"

_, err := svr.Query(c, &req)

- So(err, ShouldBeRPCNotFound)

+ So(err, ShouldBeRPCPermissionDenied)

})

Convey(`An empty query will include purged streams if admin.`, func() {