appengine/logdog/coordinator/endpoints/logs/list.go - Issue 1971493003: LogDog: Project READ access for user endpoints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/logdog/coordinator/endpoints/logs/list.go

Issue 1971493003: LogDog: Project READ access for user endpoints. (Closed) Base URL: https://github.com/luci/luci-go@logdog-project-service-config

Patch Set: Updated patchset dependency Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/logdog/coordinator/context.go ('K') | « appengine/logdog/coordinator/endpoints/logs/get_test.go ('k') | appengine/logdog/coordinator/endpoints/logs/list_test.go » ('j') | appengine/logdog/coordinator/endpoints/services/registerStream.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/logdog/coordinator/endpoints/logs/list.go

diff --git a/appengine/logdog/coordinator/endpoints/logs/list.go b/appengine/logdog/coordinator/endpoints/logs/list.go

index 14a5b0b0024b2fbeb6d81e3449e7d59fed1a5a3e..e40b0a3f72ca16fc0284104ff14eb831fa5ab73c 100644

--- a/appengine/logdog/coordinator/endpoints/logs/list.go

+++ b/appengine/logdog/coordinator/endpoints/logs/list.go

@@ -7,7 +7,6 @@ package logs

import (

ds "github.com/luci/gae/service/datastore"

"github.com/luci/luci-go/appengine/logdog/coordinator"

- "github.com/luci/luci-go/appengine/logdog/coordinator/config"

"github.com/luci/luci-go/appengine/logdog/coordinator/hierarchy"

"github.com/luci/luci-go/common/api/logdog_coordinator/logs/v1"

"github.com/luci/luci-go/common/grpcutil"

@@ -59,12 +58,7 @@ func (s *server) List(c context.Context, req *logdog.ListRequest) (*logdog.ListR

l, err := hierarchy.Get(c, hr)

if err != nil {

log.WithError(err).Errorf(c, "Failed to get hierarchy listing.")

- if err == config.ErrNoAccess {

- // User requested a project that either doesn't exist or they don't have

- // access to.

- return nil, grpcutil.NotFound

- }

- return nil, grpcutil.InvalidArgument

+ return nil, getGRPCError(c, err)

}

resp := logdog.ListResponse{