LogDog: Project READ access for user endpoints.

appengine/logdog/coordinator/hierarchy/hierarchy_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package hierarchy
 
 import (
         "fmt"
         "testing"
 
         ds "github.com/luci/gae/service/datastore"
         "github.com/luci/gae/service/info"
         "github.com/luci/luci-go/appengine/logdog/coordinator"
-        "github.com/luci/luci-go/appengine/logdog/coordinator/config"
         ct "github.com/luci/luci-go/appengine/logdog/coordinator/coordinatorTest"
         luciConfig "github.com/luci/luci-go/common/config"
         "github.com/luci/luci-go/common/logdog/types"
 
         . "github.com/smartystreets/goconvey/convey"
 )
 
 func TestHierarchy(t *testing.T) {
         t.Parallel()
 
@@ skipping 90 matching lines @@
                                         So(l, lv.shouldHaveComponents)
                                         So(l.Next, ShouldEqual, "")
                                 })
                         })
                 })
 
                 Convey(`Get within a project that the user cannot access will return ErrNoAccess.`, func() {
                         r.Project = "proj-exclusive"
 
                         _, err := Get(c, r)
-                        So(err, ShouldEqual, config.ErrNoAccess)
+                        So(coordinator.IsMembershipError(err), ShouldBeTrue)
                 })
 
                 Convey(`Get will return nothing when no components are registered.`, func() {
                         r.Project = "proj-foo"
                         lv.project = "proj-foo"
 
                         So(get(), lv.shouldHaveComponents)
 
                         r.PathBase = "foo"
                         lv.pathBase = "foo"
@@ skipping 159 matching lines @@
 func norm(c []*ListComponent) []string {
         result := make([]string, len(c))
         for i, e := range c {
                 result[i] = e.Name
                 if e.Stream {
                         result[i] += "$"
                 }
         }
         return result
 }