LogDog: Project READ access for user endpoints.

appengine/logdog/coordinator/endpoints/logs/list.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package logs
 
 import (
         ds "github.com/luci/gae/service/datastore"
         "github.com/luci/luci-go/appengine/logdog/coordinator"
-        "github.com/luci/luci-go/appengine/logdog/coordinator/config"
         "github.com/luci/luci-go/appengine/logdog/coordinator/hierarchy"
         "github.com/luci/luci-go/common/api/logdog_coordinator/logs/v1"
         "github.com/luci/luci-go/common/grpcutil"
         log "github.com/luci/luci-go/common/logging"
         "golang.org/x/net/context"
         "google.golang.org/grpc/codes"
 )
 
 const (
         // listResultLimit is the maximum number of log streams that will be
@@ skipping 31 matching lines @@
                         return nil, grpcutil.Errf(codes.PermissionDenied, "non-admin user cannot request purged log paths")
                 }
 
                 // TODO(dnj): Apply this to the hierarchy request, when purging is
                 // enabled.
         }
 
         l, err := hierarchy.Get(c, hr)
         if err != nil {
                 log.WithError(err).Errorf(c, "Failed to get hierarchy listing.")
-                if err == config.ErrNoAccess {
-                        // User requested a project that either doesn't exist or they don't have
-                        // access to.
-                        return nil, grpcutil.NotFound
-                }
-                return nil, grpcutil.InvalidArgument
+                return nil, getGRPCError(c, err)
         }
 
         resp := logdog.ListResponse{
                 Project:  string(l.Project),
                 Next:     l.Next,
                 PathBase: string(l.PathBase),
         }
 
         if len(l.Comp) > 0 {
                 resp.Components = make([]*logdog.ListResponse_Component, len(l.Comp))
@@ skipping 78 matching lines @@
                                 }
                         }
                 }
         }
 
         log.Fields{
                 "count": len(resp.Components),
         }.Infof(c, "List completed successfully.")
         return &resp, nil
 }