LogDog: Project READ access for user endpoints.

appengine/logdog/coordinator/endpoints/services/registerStream_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package services
 
 import (
         "errors"
         "testing"
         "time"
@@ skipping 11 matching lines @@
 
         . "github.com/luci/luci-go/common/testing/assertions"
         . "github.com/smartystreets/goconvey/convey"
 )
 
 func TestRegisterStream(t *testing.T) {
         t.Parallel()
 
         Convey(`With a testing configuration`, t, func() {
                 c, env := ct.Install()
-                env.ModServiceConfig(c, func(cfg *svcconfig.Coordinator) {
-                        cfg.ArchiveDelayMax = google.NewDuration(time.Hour)
+                ds.Get(c).Testable().Consistent(true)
+
+                // Set our archival delays. The project delay is smaller than the service
+                // delay, so it should be used.
+                env.ModServiceConfig(c, func(cfg *svcconfig.Config) {
+                        cfg.Coordinator.ArchiveDelayMax = google.NewDuration(24 * time.Hour)
                 })
-                ds.Get(c).Testable().Consistent(true)
+                env.ModProjectConfig(c, "proj-foo", func(pcfg *svcconfig.ProjectConfig) {
+                        pcfg.MaxStreamAge = google.NewDuration(time.Hour)
+                })
 
                 svr := New()
 
                 Convey(`Returns Forbidden error if not a service.`, func() {
                         _, err := svr.RegisterStream(c, &logdog.RegisterStreamRequest{})
                         So(err, ShouldBeRPCPermissionDenied)
                 })
 
                 Convey(`When logged in as a service`, func() {
                         env.JoinGroup("services")
@@ skipping 90 matching lines @@
                                                 })
                                         })
 
                                         Convey(`Will not re-register if secrets don't match.`, func() {
                                                 req.Secret[0] = 0xAB
                                                 _, err := svr.RegisterStream(c, &req)
                                                 So(err, ShouldBeRPCAlreadyExists, "Log prefix is already registered")
                                         })
                                 })
 
+                                Convey(`Will schedule the correct archival expiration delay`, func() {
+                                        Convey(`When there is no project config delay.`, func() {
+                                                env.ModProjectConfig(c, "proj-foo", func(pcfg *svcconfig.ProjectConfig) {
+                                                        pcfg.MaxStreamAge = nil
+                                                })
+
+                                                _, err := svr.RegisterStream(c, &req)
+                                                So(err, ShouldBeRPCOK)
+                                                ds.Get(c).Testable().CatchupIndexes()
+
+                                                // The cleanup archival should be scheduled for 24 hours, so advance
+                                                // 12, confirm no archival, then advance another 12 and confirm that
+                                                // archival was tasked.
+                                                env.Clock.Add(12 * time.Hour)
+                                                env.DrainTumbleAll(c)
+                                                So(env.ArchivalPublisher.Hashes(), ShouldHaveLength, 0)
+
+                                                env.Clock.Add(12 * time.Hour)
+                                                env.DrainTumbleAll(c)
+                                                So(env.ArchivalPublisher.Hashes(), ShouldResemble, []string{string(tls.Stream.ID)})
+                                        })
+
+                                        Convey(`When there is no service or project config delay.`, func() {
+                                                env.ModServiceConfig(c, func(cfg *svcconfig.Config) {
+                                                        cfg.Coordinator.ArchiveDelayMax = nil
+                                                })
+                                                env.ModProjectConfig(c, "proj-foo", func(pcfg *svcconfig.ProjectConfig) {
+                                                        pcfg.MaxStreamAge = nil
+                                                })
+
+                                                _, err := svr.RegisterStream(c, &req)
+                                                So(err, ShouldBeRPCOK)
+                                                ds.Get(c).Testable().CatchupIndexes()
+
+                                                // The cleanup archival should be scheduled immediately.
+                                                env.DrainTumbleAll(c)
+                                                So(env.ArchivalPublisher.Hashes(), ShouldResemble, []string{string(tls.Stream.ID)})
+                                        })
+                                })
+
                                 Convey(`Returns internal server error if the datastore Get() fails.`, func() {
                                         c, fb := featureBreaker.FilterRDS(c, nil)
                                         fb.BreakFeatures(errors.New("test error"), "GetMulti")
 
                                         _, err := svr.RegisterStream(c, &req)
                                         So(err, ShouldBeRPCInternal)
                                 })
 
                                 Convey(`Returns internal server error if the Prefix Put() fails.`, func() {
                                         c, fb := featureBreaker.FilterRDS(c, nil)
@@ skipping 58 matching lines @@
                                                 fb.BreakFeatures(errors.New("test error"), "PutMulti")
 
                                                 _, err := rsm.RollForward(c)
                                                 So(err, ShouldBeRPCInternal)
                                         })
                                 })
                         })
                 })
         })
 }