MD Settings: About page, porting C++ handler and adding browser proxy.

chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview A helper object used from the "About" section to interact with
+ * the browser.
+ */
+
+/**
+ * @typedef {{
+ *   text: string,
+ *   url: string,
+ * }}
+ */
+var RegulatoryInfo;

[tommycli, 2016/05/10 20:45:39]

If this is indeed used only in chromeos, can we <if> out this typedef also?

[dpapad, 2016/05/10 22:03:02]

Done.

+
+cr.define('settings', function() {
+  /**
+   * Enumeration of all possible browser channels.
+   * @enum {string}
+   */
+  var BrowserChannel = {
+    BETA: 'beta-channel',
+    DEV: 'dev-channel',
+    STABLE: 'stable-channel',
+  };
+
+  /** @interface */
+  function AboutPageBrowserProxy() {}
+
+  AboutPageBrowserProxy.prototype = {
+    /**
+     * Called once the page is ready. It results in one or more
+     * 'update-status-changed' WebUI events.
+     */
+    refreshUpdateStatus: function() {},
+
+    /**
+     * Relaunches the browser.
+     */
+    relaunchNow: function() {},
+
+    /** Opens the help page. */
+    openHelpPage: function() {},
+
+<if expr="_google_chrome">
+    /**
+     * Opens the feedback dialog.
+     */
+    openFeedbackDialog: function() {},
+</if>
+
+<if expr="chromeos">
+    requestUpdate: function() {},

[tommycli, 2016/05/10 20:45:39]

Does this one need a comment also?

[dpapad, 2016/05/10 22:03:02]

Done.

+
+    /**
+     * @param {!BrowserChannel} channel
+     * @param {boolean} isPowerwashAllowed
+     */
+    setChannel: function(channel, isPowerwashAllowed) {},
+
+    /** @return {!Promise<string>} */
+    getCurrentChannel: function() {},
+
+    /** @return {!Promise<string>} */
+    getTargetChannel: function() {},
+
+    /** @return {!Promise<string>} */
+    getOsVersion: function() {},
+
+    /** @return {!Promise<string>} */
+    getOsFirmware: function() {},
+
+    /** @return {!Promise<string>} */
+    getArcVersion: function() {},
+
+    /** @return {!Promise<?RegulatoryInfo>} */
+    getRegulatoryInfo: function() {},
+</if>
+  };
+
+  /**
+   * @implements {settings.AboutPageBrowserProxy}
+   * @constructor
+   */
+  function AboutPageBrowserProxyImpl() {}
+  cr.addSingletonGetter(AboutPageBrowserProxyImpl);
+
+  AboutPageBrowserProxyImpl.prototype = {
+    /** @override */
+    refreshUpdateStatus: function() {
+      chrome.send('refreshUpdateStatus');
+    },
+
+    /** @override */
+    relaunchNow: function() {
+      chrome.send('relaunchNow');
+    },
+
+    /** @override */
+    openHelpPage: function() {
+      chrome.send('openHelpPage');
+    },
+
+<if expr="_google_chrome">
+    /** @override */
+    openFeedbackDialog: function() {
+      chrome.send('openFeedbackDialog');
+    },
+</if>
+
+<if expr="chromeos">
+    /** @override */
+    requestUpdate: function() {
+      chrome.send('requestUpdate');
+    },
+
+    /** @override */
+    setChannel: function(channel, isPowerwashAllowed) {
+      chrome.send('setChannel', [channel, isPowerwashAllowed]);
+    },
+
+    /** @override */
+    getCurrentChannel: function() {
+      return cr.sendWithPromise('getCurrentChannel');
+    },
+
+    /** @override */
+    getTargetChannel: function() {
+      return cr.sendWithPromise('getTargetChannel');
+    },
+
+    /** @override */
+    getOsVersion: function() {
+      return cr.sendWithPromise('getOsVersion');
+    },
+
+    /** @override */
+    getOsFirmware: function() {
+      return cr.sendWithPromise('getOsFirmware');
+    },
+
+    /** @override */
+    getArcVersion: function() {
+      return cr.sendWithPromise('getArcVersion');
+    },
+
+    /** @override */
+    getRegulatoryInfo: function() {
+      return cr.sendWithPromise('getRegulatoryInfo');
+    }
+</if>
+  };
+
+  return {
+    AboutPageBrowserProxy: AboutPageBrowserProxy,
+    AboutPageBrowserProxyImpl: AboutPageBrowserProxyImpl,
+  };
+});