Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: third_party/WebKit/Source/core/input/TouchEventManager.h

Issue 1971473002: Move touch hit testing to PointerEventManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove stale code Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/TouchEventManager.h
diff --git a/third_party/WebKit/Source/core/input/TouchEventManager.h b/third_party/WebKit/Source/core/input/TouchEventManager.h
index d5762143646b246a40c6b8549d317a99e05abf4f..7a3fe5cbd3f0c1fa773b38438379f535970c27d3 100644
--- a/third_party/WebKit/Source/core/input/TouchEventManager.h
+++ b/third_party/WebKit/Source/core/input/TouchEventManager.h
@@ -40,7 +40,6 @@ public:
FloatPoint contentPoint;
FloatSize adjustedRadius;
bool knownTarget;
- bool consumed;
String region;
};
@@ -48,14 +47,15 @@ public:
~TouchEventManager();
DECLARE_TRACE();
- // Returns true if it succesfully generates touchInfos.
- bool generateTouchInfosAfterHittest(
+ // Does the hit-testing again if the original hit test result was not inside
Rick Byers 2016/05/17 14:20:01 nit: what does the return value mean?
Navid Zolghadr 2016/05/17 16:40:44 Done.
+ // capturing frame for touch events.
+ bool reHitTestTouchPointsIfNeeded(
const PlatformTouchEvent&,
HeapVector<TouchInfo>&);
WebInputEventResult handleTouchEvent(
Rick Byers 2016/05/17 14:20:01 add comment describing how touchinfos are modified
Navid Zolghadr 2016/05/17 16:40:44 I added a comment. However the caller of the funct
const PlatformTouchEvent&,
- const HeapVector<TouchInfo>&);
+ HeapVector<TouchInfo>&);
// Resets the internal state of this object.
void clear();

Powered by Google App Engine
This is Rietveld 408576698