third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-capture-in-iframe.html - Issue 1971473002: Move touch hit testing to PointerEventManager

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-capture-in-iframe.html

Issue 1971473002: Move touch hit testing to PointerEventManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove stale code Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-capture-in-iframe-expected.txt » ('j') | third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-capture-in-iframe-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>
	Rick Byers 2016/05/17 14:20:01 Thanks for the thorough test! Not sure if the func Thanks for the thorough test! Not sure if the functionality is ready yet, but it would also be valuable to have an uncaptured variant of this test (which does releasePointerCapture on each touch). In particular, the interaction with touch events when the finger is uncaptured is ... "interesting". Navid Zolghadr 2016/05/17 16:40:44 As you guessed, the functionality is not here yet. Show quoted text On 2016/05/17 14:20:01, Rick Byers wrote: > Thanks for the thorough test! > Not sure if the functionality is ready yet, but it would also be valuable to > have an uncaptured variant of this test (which does releasePointerCapture on > each touch). In particular, the interaction with touch events when the finger > is uncaptured is ... "interesting". As you guessed, the functionality is not here yet. That will be the very next change after this change to add that and I will add that test scenarios here in that case.
	2 <script src='../../../../../resources/js-test.js'></script>

	3 <style>

	4 iframe {

	5 width: 300px;

	6 height: 300px;

	7 top: 100px;

	8 left: 50px;

	9 border: 0;

	10 position: absolute;

	11 background: green;

	12 }

	13 #outerFrame {

	14 width: 500px;

	15 height: 500px;

	16 background: blue;

	17 }

	18 </style>

	19

	20 <body>
	Rick Byers 2016/05/17 14:20:01 nit: layout tests normally omit body tags: https:/ nit: layout tests normally omit body tags: https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... Navid Zolghadr 2016/05/17 16:40:44 Done. Show quoted text On 2016/05/17 14:20:01, Rick Byers wrote: > nit: layout tests normally omit body tags: > https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... Done.
	21 <div id='outerFrame'>

	22 <iframe id='innerFrameElement' srcdoc="

	23 <body id='innerFrame' style='height:500px; width: 500px; padding: 0; margin: 0 ;'>

	24 <script>

	25 top.document.testEventList.forEach(function(eventName) {

	26 document.documentElement.addEventListener(eventName, function(event) {

	27 top.document.events.push(event);

	28 });

	29 });

	30 </script>

	31 </body>">

	32 </iframe>

	33 </div>

	34

	35 <div id='console'></div>

	36

	37 <script>

	38 var outerFrameX = 20;

	39 var outerFrameY = 20;

	40 var innerFrameX = 200;

	41 var innerFrameY = 200;

	42

	43 document.testEventList = ['pointerup', 'pointerdown', 'pointermove', 'gotpointer capture', 'lostpointercapture', 'pointercancel',

	44 'touchstart', 'touchmove', 'touchend'];

	45 document.testEventList.forEach(function(eventName) {

	46 document.getElementById('outerFrame').addEventListener(eventName, function(eve nt) {

	47 document.events.push(event);

	48 });

	49 });

	50

	51 var attributes = [

	52 'target'

	53 ];

	54

	55 document.events = [];

	56

	57 function testScenario(firstFingerInitFrame, secondFingerInitFrame) {

	58 var firstFingerX1 = firstFingerInitFrame == "innerFrame" ? innerFrameX : outer FrameX;

	59 var firstFingerY1 = firstFingerInitFrame == "innerFrame" ? innerFrameY : outer FrameY;

	60 var firstFingerX2 = firstFingerInitFrame == "outerFrame" ? innerFrameX : outer FrameX;

	61 var firstFingerY2 = firstFingerInitFrame == "outerFrame" ? innerFrameY : outer FrameY;

	62 var secondFingerX1 = secondFingerInitFrame == "innerFrame" ? innerFrameX : out erFrameX;

	63 var secondFingerY1 = secondFingerInitFrame == "innerFrame" ? innerFrameY : out erFrameY;

	64 var secondFingerX2 = secondFingerInitFrame == "outerFrame" ? innerFrameX : out erFrameX;

	65 var secondFingerY2 = secondFingerInitFrame == "outerFrame" ? innerFrameY : out erFrameY;

	66 var firstFingerFinalFrame = (firstFingerInitFrame == 'innerFrame') ? 'outerFra me' : 'innerFrame';

	67 var secondFingerFinalFrame = (secondFingerInitFrame == 'innerFrame') ? 'outerF rame' : 'innerFrame';

	68

	69 debug('==== Finger1 in ' + firstFingerInitFrame + ' and Finger2 in ' + secondF ingerInitFrame + ' ====');

	70 debug('* Put first finger down in ' + firstFingerInitFrame + ' and move *' );

	71 eventSender.addTouchPoint(firstFingerX1, firstFingerY1);

	72 eventSender.touchStart();

	73 eventSender.updateTouchPoint(0, firstFingerX1, firstFingerY1);

	74 eventSender.touchMove();

	75 dumpEvents();

	76

	77 debug('* Put second finger in ' + secondFingerInitFrame + ' and move *');

	78 eventSender.addTouchPoint(secondFingerX1, secondFingerY1);

	79 eventSender.touchStart();

	80 eventSender.updateTouchPoint(1, secondFingerX1, secondFingerY1);

	81 eventSender.touchMove();

	82 dumpEvents();

	83

	84 debug('* Move first finger to ' + firstFingerFinalFrame + ' *');

	85 eventSender.updateTouchPoint(0, firstFingerX2, firstFingerY2);

	86 eventSender.touchMove();

	87 dumpEvents();

	88

	89 debug('* Move second finger to ' + secondFingerFinalFrame + ' *');

	90 eventSender.updateTouchPoint(1, secondFingerX2, secondFingerY2);

	91 eventSender.touchMove();

	92 dumpEvents();

	93

	94 debug('* Releasing fingers *');

	95 eventSender.releaseTouchPoint(0);

	96 eventSender.releaseTouchPoint(1);

	97 eventSender.touchEnd();

	98 dumpEvents();

	99 }

	100

	101 function runTests() {

	102 testScenario('innerFrame', 'outerFrame');

	103 testScenario('outerFrame', 'innerFrame');

	104 testScenario('innerFrame', 'innerFrame');

	105 testScenario('outerFrame', 'outerFrame');

	106 testRunner.notifyDone();

	107 }

	108

	109 function dumpEvents()

	110 {

	111 document.events.forEach(function(event) {

	112 if (event.type.includes('pointer')) {

	113 debug(event.target.id + ' recieved ' + event.type);

	114 } else if (event.type.startsWith('touch')) {

	115 debug(event.type + ' is recieved with changedTouches.length=' + event.chan gedTouches.length + ':');

	116 for(var i=0; i<event.changedTouches.length; i++) {

	117 debug(' Touch with id=' + event.changedTouches[i].identifier + ' with t arget = ' + event.changedTouches[i].target.id);

	118 }

	119 }

	120 });

	121 debug('');

	122 document.events = [];

	123 }

	124

	125 if (window.eventSender) {

	126 testRunner.waitUntilDone();

	127 window.onload = runTests;

	128 } else

	129 debug('This test requires eventSender');

	130

	131 description("This test verifies clientX/Y of pointer events inside iframe.");
	Rick Byers 2016/05/17 14:20:01 This description seems wrong. This description seems wrong. Navid Zolghadr 2016/05/17 16:40:44 Right. I copy pasted from the other test and forgo Show quoted text On 2016/05/17 14:20:01, Rick Byers wrote: > This description seems wrong. Right. I copy pasted from the other test and forgot to change the description or remove the body tag.
	132

	133 </script>

	134 </body>

OLD	NEW