Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3947)

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

Issue 1971463002: Get rid of some lingering MD-specific raster assets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: msw review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
index b6660cb0d0470ee194a0a1c35610a87f0fdaa348..73ef201e4f8c8f7035ae326dc1c9b70105df7237 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
@@ -119,8 +119,6 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, DragBrowserActions) {
// Shrink the size of the container so we have an overflow menu.
toolbar_model()->SetVisibleIconCount(2u);
EXPECT_EQ(2u, container->VisibleBrowserActions());
- ASSERT_TRUE(container->chevron());
- EXPECT_TRUE(container->chevron()->visible());
// Simulate a drag and drop from the overflow menu.
ui::OSExchangeData drop_data3;
@@ -143,13 +141,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, DragBrowserActions) {
EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(1));
EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(2));
EXPECT_EQ(3u, container->VisibleBrowserActions());
- EXPECT_FALSE(container->chevron()->visible());
EXPECT_TRUE(toolbar_model()->all_icons_visible());
-
- // TODO(devlin): Ideally, we'd also have tests for dragging from the legacy
- // overflow menu (i.e., chevron) to the main bar, but this requires either
- // having a fairly complicated interactive UI test or finding a good way to
- // mock up the BrowserActionOverflowMenuController.
}
// Test that changes performed in one container affect containers in other
@@ -194,8 +186,6 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, MultipleWindows) {
// Semi-random placement for a regression test for crbug.com/539744.
first->Layout();
- EXPECT_FALSE(first->chevron_for_testing()->visible());
-
first->OnPerformDrop(target_event);
// The new order, B A C, should be reflected in *both* containers, even
@@ -212,8 +202,6 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, MultipleWindows) {
// The first and second container should each have resized.
EXPECT_EQ(2u, first->VisibleBrowserActions());
EXPECT_EQ(2u, second->VisibleBrowserActions());
- EXPECT_TRUE(first->chevron_for_testing()->visible());
- EXPECT_TRUE(second->chevron_for_testing()->visible());
}
// Test that the BrowserActionsContainer responds correctly when the underlying
« no previous file with comments | « chrome/browser/ui/views/toolbar/browser_actions_container.cc ('k') | chrome/browser/ui/views/toolbar/chevron_menu_button.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698