Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6972)

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 1971463002: Get rid of some lingering MD-specific raster assets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: msw review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
index d74aa28e0c7b996a6b183bb21f9029fbaa1f20fa..61e48283110295537f9ac3537c9e86eaace6cd81 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
@@ -130,14 +130,6 @@ void ExtensionInstalledBubbleView::UpdateAnchorView() {
DCHECK(!container->animating());
reference_view = container->GetViewForId(controller_->extension()->id());
- // If the view is not visible then it is in the chevron, so point the
- // install bubble to the chevron instead. If this is an incognito window,
- // both could be invisible.
- if (!reference_view || !reference_view->visible()) {
- reference_view = container->chevron();
- if (!reference_view || !reference_view->visible())
- reference_view = nullptr; // fall back to app menu below.
- }
break;
}
case ExtensionInstalledBubble::ANCHOR_PAGE_ACTION: {
@@ -161,7 +153,7 @@ void ExtensionInstalledBubbleView::UpdateAnchorView() {
}
// Default case.
- if (!reference_view)
+ if (!reference_view || !reference_view->visible())
reference_view = browser_view->GetToolbarView()->app_menu_button();
SetAnchorView(reference_view);
}
« no previous file with comments | « chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc ('k') | chrome/browser/ui/views/ime/ime_warning_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698