Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1971443005: <track> should not have end tags (Closed)

Created:
4 years, 7 months ago by wychen
Modified:
4 years, 7 months ago
Reviewers:
mdjones
CC:
ramya.v
Base URL:
git@github.com:chromium/dom-distiller.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

<track> should not have end tags Disable tests containing <track> in CI. They can be re-enabled after https://codereview.chromium.org/1967493002/ is available. BUG=521771 R=mdjones@chromium.org Committed: 0adf24afe43c18d039780d4fe1528f241880ddf7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M .travis.yml View 1 chunk +1 line, -1 line 0 comments Download
M javatests/org/chromium/distiller/DomUtilTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M javatests/org/chromium/distiller/webdocument/WebVideoTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
wychen
PTAL. This one should be rolled separately, and commit with https://codereview.chromium.org/1967493002/ atomically.
4 years, 7 months ago (2016-05-11 21:16:25 UTC) #2
wychen
CI passed. https://travis-ci.org/wychen/dom-distiller/builds/129545710
4 years, 7 months ago (2016-05-11 21:39:26 UTC) #3
mdjones
lgtm
4 years, 7 months ago (2016-05-11 22:42:25 UTC) #4
wychen
4 years, 7 months ago (2016-05-11 22:47:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0adf24afe43c18d039780d4fe1528f241880ddf7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698