Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Issue 1971393003: Revert of [Editing][Stability] Recanonicalize m_originalbase in FrameSelection (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Editing][Stability] Recanonicalize m_originalbase in FrameSelection (patchset #5 id:120001 of https://codereview.chromium.org/1793093006/ ) Reason for revert: Causes unexpected leak reliably https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/19495/steps/webkit_tests/logs/stdio 02:43:31.446 20471 worker/6 editing/selection/mouse/drag_selection_update_crash.html leaked 02:43:31.447 20404 [15652/40740] editing/selection/mouse/drag_selection_update_crash.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,4],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,18],"numberOfLiveResources":[0,2]})) 02:43:31.446 20471 worker/6 editing/selection/mouse/drag_selection_update_crash.html failed: 02:43:31.446 20471 worker/6 leak detected: ({"numberOfLiveActiveDOMObjects":[2,4],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,18],"numberOfLiveResources":[0,2]}) Original issue's description: > [Editing][Stability] Recanonicalize m_originalbase in FrameSelection > > The crash issue 562339 is caused in computeInlineBoxPositionTemplate called in the > RenderPosition constructor. > The root issue is FrameSelection::setNonDirectionalSelectionIfNeededAlgorithm > uses m_originalBase as up-to-date. > m_originBase is used only in the function. > However, there can be layout by next call. > Thus this CL recanonicalizes m_originalBase. > > BUG=562339, 593592 > > Committed: https://crrev.com/1c6aad352c275e7965fb4f32cebcdf5b261af704 > Cr-Commit-Position: refs/heads/master@{#393483} TBR=yosin@chromium.org,yoichio@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=562339, 593592 Committed: https://crrev.com/7418382eca49a0e2b0dd8cc081ce89aa77b3e4e5 Cr-Commit-Position: refs/heads/master@{#393505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -33 lines) Patch
D third_party/WebKit/LayoutTests/editing/selection/mouse/drag_selection_update_crash.html View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 2 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vasilii
Created Revert of [Editing][Stability] Recanonicalize m_originalbase in FrameSelection
4 years, 7 months ago (2016-05-13 12:16:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971393003/1
4 years, 7 months ago (2016-05-13 12:16:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 12:17:06 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 12:18:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7418382eca49a0e2b0dd8cc081ce89aa77b3e4e5
Cr-Commit-Position: refs/heads/master@{#393505}

Powered by Google App Engine
This is Rietveld 408576698