Chromium Code Reviews
DescriptionRevert of [Editing][Stability] Recanonicalize m_originalbase in FrameSelection (patchset #5 id:120001 of https://codereview.chromium.org/1793093006/ )
Reason for revert:
Causes unexpected leak reliably https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/19495/steps/webkit_tests/logs/stdio
02:43:31.446 20471 worker/6 editing/selection/mouse/drag_selection_update_crash.html leaked
02:43:31.447 20404 [15652/40740] editing/selection/mouse/drag_selection_update_crash.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,4],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,18],"numberOfLiveResources":[0,2]}))
02:43:31.446 20471 worker/6 editing/selection/mouse/drag_selection_update_crash.html failed:
02:43:31.446 20471 worker/6 leak detected: ({"numberOfLiveActiveDOMObjects":[2,4],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,18],"numberOfLiveResources":[0,2]})
Original issue's description:
> [Editing][Stability] Recanonicalize m_originalbase in FrameSelection
>
> The crash issue 562339 is caused in computeInlineBoxPositionTemplate called in the
> RenderPosition constructor.
> The root issue is FrameSelection::setNonDirectionalSelectionIfNeededAlgorithm
> uses m_originalBase as up-to-date.
> m_originBase is used only in the function.
> However, there can be layout by next call.
> Thus this CL recanonicalizes m_originalBase.
>
> BUG=562339, 593592
>
> Committed: https://crrev.com/1c6aad352c275e7965fb4f32cebcdf5b261af704
> Cr-Commit-Position: refs/heads/master@{#393483}
TBR=yosin@chromium.org,yoichio@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=562339, 593592
Committed: https://crrev.com/7418382eca49a0e2b0dd8cc081ce89aa77b3e4e5
Cr-Commit-Position: refs/heads/master@{#393505}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||