Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: media/blink/multibuffer_reader.cc

Issue 1971373002: Fix progress reporting for multibuffers to report progress for every byte we receive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/multibuffer_data_source_unittest.cc ('k') | media/blink/multibuffer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/multibuffer_reader.cc
diff --git a/media/blink/multibuffer_reader.cc b/media/blink/multibuffer_reader.cc
index 166de54ce959557bfd7730baa9fa2d1da055444c..d774720345128071a62fa870ab25616e21656a4f 100644
--- a/media/blink/multibuffer_reader.cc
+++ b/media/blink/multibuffer_reader.cc
@@ -180,13 +180,14 @@ void MultiBufferReader::NotifyAvailableRange(
// there are no callbacks from us after we've been destroyed.
base::MessageLoop::current()->PostTask(
FROM_HERE,
- base::Bind(&MultiBufferReader::Call, weak_factory_.GetWeakPtr(),
- base::Bind(progress_callback_,
- static_cast<int64_t>(range.begin)
- << multibuffer_->block_size_shift(),
- static_cast<int64_t>(range.end)
- << multibuffer_->block_size_shift())));
- // We may be destroyed, do not touch |this|.
+ base::Bind(
+ &MultiBufferReader::Call, weak_factory_.GetWeakPtr(),
+ base::Bind(progress_callback_,
+ static_cast<int64_t>(range.begin)
+ << multibuffer_->block_size_shift(),
+ (static_cast<int64_t>(range.end)
+ << multibuffer_->block_size_shift()) +
+ multibuffer_->UncommittedBytesAt(range.end))));
}
}
« no previous file with comments | « media/blink/multibuffer_data_source_unittest.cc ('k') | media/blink/multibuffer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698