media/blink/multibuffer_reader.cc - Issue 1971373002: Fix progress reporting for multibuffers to report progress for every byte we receive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/multibuffer_reader.cc

Issue 1971373002: Fix progress reporting for multibuffers to report progress for every byte we receive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: documentation added Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/blink/multibuffer.h ('K') | « media/blink/multibuffer_data_source_unittest.cc ('k') | media/blink/multibuffer_unittest.cc » ('j') | media/blink/resource_multibuffer_data_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/blink/multibuffer_reader.cc

diff --git a/media/blink/multibuffer_reader.cc b/media/blink/multibuffer_reader.cc

index 166de54ce959557bfd7730baa9fa2d1da055444c..2b41d35282d8cbff27ddbc1a92c1368376ffc037 100644

--- a/media/blink/multibuffer_reader.cc

+++ b/media/blink/multibuffer_reader.cc

@@ -180,12 +180,14 @@ void MultiBufferReader::NotifyAvailableRange(

// there are no callbacks from us after we've been destroyed.

base::MessageLoop::current()->PostTask(

FROM_HERE,

- base::Bind(&MultiBufferReader::Call, weak_factory_.GetWeakPtr(),

- base::Bind(progress_callback_,

- static_cast<int64_t>(range.begin)

- << multibuffer_->block_size_shift(),

- static_cast<int64_t>(range.end)

- << multibuffer_->block_size_shift())));

+ base::Bind(

+ &MultiBufferReader::Call, weak_factory_.GetWeakPtr(),

+ base::Bind(progress_callback_,

+ static_cast<int64_t>(range.begin)

+ << multibuffer_->block_size_shift(),

+ (static_cast<int64_t>(range.end)

+ << multibuffer_->block_size_shift()) +

+ multibuffer_->UncommittedBytesAt(range.end))));

// We may be destroyed, do not touch |this|.

liberato (no reviews please) 2016/05/13 17:45:55 i think this comment is out of date, since it post

hubbe 2016/05/13 17:51:36 Done.

}