Abort stencil draws when the attachment fails

Abort stencil draws when the attachment fails

BUG=skia:611514
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971353003

Committed: https://skia.googlesource.com/skia/+/17bf82052f8916c62848c5a3c1d600062bbd8c30

[Chris Dalton, 2016-05-13 16:55:48]

Description was changed from

==========
Abort stencil draws when the attachment fails

BUG=skia:611514
==========

to

==========
Abort stencil draws when the attachment fails

BUG=skia:611514
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Chris Dalton, 2016-05-13 16:56:55]

cdalton@nvidia.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[Chris Dalton, 2016-05-13 16:56:55]

https://codereview.chromium.org/1971353003/diff/1/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/1971353003/diff/1/src/gpu/GrDrawTarget.cpp#ne...
src/gpu/GrDrawTarget.cpp:259: return;
Do we want to fail silently or print a debug message?

[bsalomon, 2016-05-13 17:43:01]

lgtm

https://codereview.chromium.org/1971353003/diff/1/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/1971353003/diff/1/src/gpu/GrDrawTarget.cpp#ne...
src/gpu/GrDrawTarget.cpp:259: return;
On 2016/05/13 16:56:55, Chris Dalton wrote:
> Do we want to fail silently or print a debug message?

It's probably a good idea to print here for now. We can always remove it if it
turns out there is a reasonable condition under which this fails and the message
is annoying.

[Chris Dalton, 2016-05-13 18:03:08]

https://codereview.chromium.org/1971353003/diff/1/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/1971353003/diff/1/src/gpu/GrDrawTarget.cpp#ne...
src/gpu/GrDrawTarget.cpp:259: return;
On 2016/05/13 17:43:01, bsalomon wrote:
> On 2016/05/13 16:56:55, Chris Dalton wrote:
> > Do we want to fail silently or print a debug message?
> 
> It's probably a good idea to print here for now. We can always remove it if it
> turns out there is a reasonable condition under which this fails and the
message
> is annoying.

Done.

[Chris Dalton, 2016-05-13 18:03:17]

The CQ bit was checked by cdalton@nvidia.com

[Chris Dalton, 2016-05-13 18:03:17]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1971353003/#ps20001
(title: "error messages")

[commit-bot: I haz the power, 2016-05-13 18:03:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971353003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971353003/20001

[commit-bot: I haz the power, 2016-05-13 18:27:18]

Description was changed from

==========
Abort stencil draws when the attachment fails

BUG=skia:611514
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Abort stencil draws when the attachment fails

BUG=skia:611514
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/17bf82052f8916c62848c5a3c1d600062bbd8c30
==========

[commit-bot: I haz the power, 2016-05-13 18:27:19]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/17bf82052f8916c62848c5a3c1d600062bbd8c30