Add ImageData-related API to OffscreenCanvasRenderingContext2D

Add ImageData-related API to OffscreenCanvasRenderingContext2D

BUG=563856
Committed: https://crrev.com/b5ad91ea5bbd69c5615cc89c6c46257f4525f23a
Cr-Commit-Position: refs/heads/master@{#393550}

[xlai (Olivia), 2016-05-12 22:10:57]

xlai@chromium.org changed reviewers:
+ junov@chromium.org

[xlai (Olivia), 2016-05-12 22:10:57]

Last patch to add existing CRC2D API to OCRC2D before we move to other
functions.

[xlai (Olivia), 2016-05-13 14:29:00]

Description was changed from

==========
Add ImageData-related API to OffscreenCanvasRenderingContext2D

BUG=563856
==========

to

==========
Add ImageData-related API to OffscreenCanvasRenderingContext2D

BUG=563856
==========

[xlai (Olivia), 2016-05-13 14:29:00]

xlai@chromium.org changed reviewers:
+ ajuma@chromium.org, xidachen@chromium.org

[ajuma, 2016-05-13 15:13:31]

Just a couple questions about the "createImageData(ImageData)" case:

https://codereview.chromium.org/1971353002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageData-in-worker.html
(right):

https://codereview.chromium.org/1971353002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageData-in-worker.html:35:
var blankImageData = ctx.createImageData(getPrefilledImageData());
This one isn't really blank, right? Would prefilledImageData be a better name?

https://codereview.chromium.org/1971353002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageData-in-worker.html:90:
if (data.content == "0")
Should this be "100" since the ImageData is coming from getPrefilledImageData?

[xlai (Olivia), 2016-05-13 15:22:28]

https://codereview.chromium.org/1971353002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageData-in-worker.html
(right):

https://codereview.chromium.org/1971353002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageData-in-worker.html:35:
var blankImageData = ctx.createImageData(getPrefilledImageData());
On 2016/05/13 15:13:31, ajuma wrote:
> This one isn't really blank, right? Would prefilledImageData be a better name?

At first I also thought so. But then when I look at the API description here for
the html canvas 2d
(https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/cre...),
it says this function only copies the width and height of the image data, not
the image itself. So I was following what the HTMLcanvas 2d context does.

https://codereview.chromium.org/1971353002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageData-in-worker.html:90:
if (data.content == "0")
On 2016/05/13 15:13:31, ajuma wrote:
> Should this be "100" since the ImageData is coming from getPrefilledImageData?

Same reason as above. This function is creating a blank imagedata.

[ajuma, 2016-05-13 15:24:03]

Ah, makes sense. lgtm

[xlai (Olivia), 2016-05-13 15:27:10]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2016-05-13 15:27:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971353002/20001

[xlai (Olivia), 2016-05-13 15:35:15]

The CQ bit was unchecked by xlai@chromium.org

[xlai (Olivia), 2016-05-13 15:45:04]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-05-13 15:45:04]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1971353002/#ps40001
(title: "Add expected results to interface listings")

[commit-bot: I haz the power, 2016-05-13 15:45:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971353002/40001

[Justin Novosad, 2016-05-13 15:49:58]

On 2016/05/13 15:45:24, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1971353002/40001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1971353002/40001

lgtm

[commit-bot: I haz the power, 2016-05-13 16:51:04]

Description was changed from

==========
Add ImageData-related API to OffscreenCanvasRenderingContext2D

BUG=563856
==========

to

==========
Add ImageData-related API to OffscreenCanvasRenderingContext2D

BUG=563856
==========

[commit-bot: I haz the power, 2016-05-13 16:51:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-13 16:52:13]

Description was changed from

==========
Add ImageData-related API to OffscreenCanvasRenderingContext2D

BUG=563856
==========

to

==========
Add ImageData-related API to OffscreenCanvasRenderingContext2D

BUG=563856

Committed: https://crrev.com/b5ad91ea5bbd69c5615cc89c6c46257f4525f23a
Cr-Commit-Position: refs/heads/master@{#393550}
==========

[commit-bot: I haz the power, 2016-05-13 16:52:14]

Patchset 3 (id:??) landed as
https://crrev.com/b5ad91ea5bbd69c5615cc89c6c46257f4525f23a
Cr-Commit-Position: refs/heads/master@{#393550}