Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1971343004: [Material][Mac] Reduced the area above tabs by 2 pts (Closed)

Created:
4 years, 7 months ago by spqchan
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Material][Mac] Reduced the area above tabs by 2 pts BUG=610185 Committed: https://crrev.com/23202f9294a90af7fd7889856a2b546f23a845bc Cr-Commit-Position: refs/heads/master@{#393940}

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : Fix for avi #

Patch Set 4 : Fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -36 lines) Patch
M chrome/browser/ui/cocoa/browser_window_layout.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.mm View 4 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout_unittest.mm View 1 2 3 4 chunks +55 lines, -27 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
spqchan
PTAL
4 years, 7 months ago (2016-05-13 21:50:43 UTC) #2
shrike
lgtm
4 years, 7 months ago (2016-05-13 21:55:53 UTC) #3
spqchan
+avi for OWNERS
4 years, 7 months ago (2016-05-13 21:57:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971343004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971343004/20001
4 years, 7 months ago (2016-05-13 21:57:52 UTC) #8
Avi (use Gerrit)
LGTM with fix. https://codereview.chromium.org/1971343004/diff/20001/chrome/browser/ui/cocoa/browser_window_layout.h File chrome/browser/ui/cocoa/browser_window_layout.h (right): https://codereview.chromium.org/1971343004/diff/20001/chrome/browser/ui/cocoa/browser_window_layout.h#newcode15 chrome/browser/ui/cocoa/browser_window_layout.h:15: extern CGFloat TabStripHeight(); If this is ...
4 years, 7 months ago (2016-05-13 22:01:12 UTC) #9
spqchan
https://codereview.chromium.org/1971343004/diff/20001/chrome/browser/ui/cocoa/browser_window_layout.h File chrome/browser/ui/cocoa/browser_window_layout.h (right): https://codereview.chromium.org/1971343004/diff/20001/chrome/browser/ui/cocoa/browser_window_layout.h#newcode15 chrome/browser/ui/cocoa/browser_window_layout.h:15: extern CGFloat TabStripHeight(); On 2016/05/13 22:01:12, Avi wrote: > ...
4 years, 7 months ago (2016-05-13 22:08:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971343004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971343004/40001
4 years, 7 months ago (2016-05-13 22:09:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/111130)
4 years, 7 months ago (2016-05-13 23:00:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971343004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971343004/60001
4 years, 7 months ago (2016-05-16 20:52:51 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-16 21:37:51 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 21:38:58 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/23202f9294a90af7fd7889856a2b546f23a845bc
Cr-Commit-Position: refs/heads/master@{#393940}

Powered by Google App Engine
This is Rietveld 408576698