src/gpu/GrBlurUtils.cpp - Issue 1971343002: Convert GrClip to an abstract base class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrBlurUtils.cpp

Issue 1971343002: Convert GrClip to an abstract base class (Closed) Base URL: https://skia.googlesource.com/skia.git@upload2_clipout

Patch Set: fix crash Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/GrBlurUtils.cpp

diff --git a/src/gpu/GrBlurUtils.cpp b/src/gpu/GrBlurUtils.cpp

index 40bd6f973bc915d69767420a66c50dc68d60004b..1e85b87dcf85b96e79731e5f6eac35250753678b 100644

--- a/src/gpu/GrBlurUtils.cpp

+++ b/src/gpu/GrBlurUtils.cpp

@@ -125,8 +125,8 @@ static sk_sp<GrTexture> create_mask_GPU(GrContext* context,

tempPaint.setCoverageSetOpXPFactory(SkRegion::kReplace_Op);

// setup new clip

- const SkRect clipRect = SkRect::MakeIWH(maskRect.width(), maskRect.height());

- GrClip clip(clipRect);

+ const SkIRect clipRect = SkIRect::MakeWH(maskRect.width(), maskRect.height());

+ GrFixedClip clip(clipRect);

// Draw the mask into maskTexture with the path's integerized top-left at

// the origin using tempPaint.

« no previous file with comments | « src/effects/SkXfermodeImageFilter.cpp ('k') | src/gpu/GrClip.cpp » ('j') | no next file with comments »