Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7732)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 1971333002: Views: factor out Combobox background and const-ify style (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix ios build break Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index 92df6f292921787449849151e346431ac06d6583..0e1f12a140b28ba3463777ebcffcc697e1a0310c 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -642,10 +642,10 @@ views::View* TranslateBubbleView::CreateViewBeforeTranslate() {
items[static_cast<size_t>(DenialComboboxIndex::NEVER_TRANSLATE_SITE)] =
l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_NEVER_TRANSLATE_SITE);
denial_combobox_model_.reset(new ui::SimpleComboboxModel(items));
- denial_combobox_ = new views::Combobox(denial_combobox_model_.get());
+ denial_combobox_ = new views::Combobox(denial_combobox_model_.get(),
+ views::Combobox::STYLE_ACTION);
denial_combobox_->set_id(COMBOBOX_ID_DENIAL);
denial_combobox_->set_listener(this);
- denial_combobox_->SetStyle(views::Combobox::STYLE_ACTION);
layout->AddView(denial_combobox_);
}
« no previous file with comments | « no previous file | ui/gfx/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698