Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: ui/views/style/mac/combobox_background_mac.h

Issue 1971333002: Views: factor out Combobox background and const-ify style (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Redo PositionArrowWithinShoulder Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/style/mac/combobox_background_mac.h
diff --git a/ui/views/style/mac/combobox_background_mac.h b/ui/views/style/mac/combobox_background_mac.h
index 5be50858d75f87e6c98a08ea52e3be7e80265fdc..d09e9da38144e7285bf317dfbdfb19f823f314f6 100644
--- a/ui/views/style/mac/combobox_background_mac.h
+++ b/ui/views/style/mac/combobox_background_mac.h
@@ -23,12 +23,17 @@ namespace views {
// Mac look and feel.
class ComboboxBackgroundMac : public Background {
public:
- ComboboxBackgroundMac();
+ // The |shoulder_width| argument is the width of the "arrows" section from the
sky 2016/05/17 16:49:22 similar naming comment.
Elly Fong-Jones 2016/05/17 17:35:05 Done.
+ // diagram above, including any necessary padding around the actual arrow.
+ explicit ComboboxBackgroundMac(int shoulder_width);
~ComboboxBackgroundMac() override;
// Background:
void Paint(gfx::Canvas* canvas, View* view) const override;
+
private:
+ int shoulder_width_;
+
DISALLOW_COPY_AND_ASSIGN(ComboboxBackgroundMac);
};

Powered by Google App Engine
This is Rietveld 408576698