Recognize Adobe RGB profiles

Recognize Adobe RGB profiles

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971203002

Committed: https://skia.googlesource.com/skia/+/f44b020ecb95121eb745f058a028f1529ee735d4

[msarett, 2016-05-12 14:13:20]

Description was changed from

==========
Recognize Adobe RGB profiles

BUG=skia:
==========

to

==========
Recognize Adobe RGB profiles

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-05-12 14:14:50]

msarett@google.com changed reviewers:
+ brianosman@google.com, herb@google.com, reed@google.com

[herb_g, 2016-05-12 17:18:22]

https://codereview.chromium.org/1971203002/diff/1/src/core/SkColorSpace.cpp
File src/core/SkColorSpace.cpp (right):

https://codereview.chromium.org/1971203002/diff/1/src/core/SkColorSpace.cpp#n...
src/core/SkColorSpace.cpp:52: static bool xyz_almost_equal(const SkMatrix44&
toXYZD50, const float* standard) {
Add Comments stating that standard is a 3x3 matrix, or you could try float
(&standard)[3][3] as the parameter.

[msarett, 2016-05-12 17:31:52]

https://codereview.chromium.org/1971203002/diff/1/src/core/SkColorSpace.cpp
File src/core/SkColorSpace.cpp (right):

https://codereview.chromium.org/1971203002/diff/1/src/core/SkColorSpace.cpp#n...
src/core/SkColorSpace.cpp:52: static bool xyz_almost_equal(const SkMatrix44&
toXYZD50, const float* standard) {
On 2016/05/12 17:18:22, herb_g wrote:
> Add Comments stating that standard is a 3x3 matrix, or you could try float
> (&standard)[3][3] as the parameter.

Done.

[msarett, 2016-05-12 20:30:57]

Patchset #4 (id:60001) has been deleted

[msarett, 2016-05-12 20:31:02]

Patchset #3 (id:40001) has been deleted

[msarett, 2016-05-16 15:41:47]

Any thoughts on this?

[herb_g, 2016-05-16 15:52:50]

lgtm

[msarett, 2016-05-16 16:01:25]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-05-16 16:01:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971203002/20001

[commit-bot: I haz the power, 2016-05-16 16:23:44]

Description was changed from

==========
Recognize Adobe RGB profiles

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Recognize Adobe RGB profiles

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/f44b020ecb95121eb745f058a028f1529ee735d4
==========

[commit-bot: I haz the power, 2016-05-16 16:23:45]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f44b020ecb95121eb745f058a028f1529ee735d4