Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: src/compiler/verifier.cc

Issue 1971163002: [turbofan] Fix optimized lowering of Math.imul. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix unittests. Reorder as pointed out by Michi. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/regress/regress-5006.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 682 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 CheckValueInputIs(node, 0, Type::Signed32()); 693 CheckValueInputIs(node, 0, Type::Signed32());
694 CheckValueInputIs(node, 1, Type::Unsigned32()); 694 CheckValueInputIs(node, 1, Type::Unsigned32());
695 CheckUpperIs(node, Type::Signed32()); 695 CheckUpperIs(node, Type::Signed32());
696 break; 696 break;
697 case IrOpcode::kNumberShiftRightLogical: 697 case IrOpcode::kNumberShiftRightLogical:
698 // (Unsigned32, Unsigned32) -> Unsigned32 698 // (Unsigned32, Unsigned32) -> Unsigned32
699 CheckValueInputIs(node, 0, Type::Unsigned32()); 699 CheckValueInputIs(node, 0, Type::Unsigned32());
700 CheckValueInputIs(node, 1, Type::Unsigned32()); 700 CheckValueInputIs(node, 1, Type::Unsigned32());
701 CheckUpperIs(node, Type::Unsigned32()); 701 CheckUpperIs(node, Type::Unsigned32());
702 break; 702 break;
703 case IrOpcode::kNumberImul:
704 // (Unsigned32, Unsigned32) -> Signed32
705 CheckValueInputIs(node, 0, Type::Unsigned32());
706 CheckValueInputIs(node, 1, Type::Unsigned32());
707 CheckUpperIs(node, Type::Signed32());
708 break;
703 case IrOpcode::kNumberClz32: 709 case IrOpcode::kNumberClz32:
704 // Unsigned32 -> Unsigned32 710 // Unsigned32 -> Unsigned32
705 CheckValueInputIs(node, 0, Type::Unsigned32()); 711 CheckValueInputIs(node, 0, Type::Unsigned32());
706 CheckUpperIs(node, Type::Unsigned32()); 712 CheckUpperIs(node, Type::Unsigned32());
707 break; 713 break;
708 case IrOpcode::kNumberCeil: 714 case IrOpcode::kNumberCeil:
709 case IrOpcode::kNumberFloor: 715 case IrOpcode::kNumberFloor:
710 case IrOpcode::kNumberRound: 716 case IrOpcode::kNumberRound:
711 case IrOpcode::kNumberTrunc: 717 case IrOpcode::kNumberTrunc:
712 // Number -> Number 718 // Number -> Number
(...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after
1356 replacement->op()->EffectOutputCount() > 0); 1362 replacement->op()->EffectOutputCount() > 0);
1357 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1363 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1358 replacement->opcode() == IrOpcode::kFrameState); 1364 replacement->opcode() == IrOpcode::kFrameState);
1359 } 1365 }
1360 1366
1361 #endif // DEBUG 1367 #endif // DEBUG
1362 1368
1363 } // namespace compiler 1369 } // namespace compiler
1364 } // namespace internal 1370 } // namespace internal
1365 } // namespace v8 1371 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/regress/regress-5006.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698