Issue 197113002: Handle percent height children of multicol containers correctly.

Issue 197113002: Handle percent height children of multicol containers correctly. (Closed)

Created:
6 years, 9 months ago by mstensho (USE GERRIT)

Modified:
6 years, 9 months ago

Reviewers:
ojan

CC:
blink-reviews, mstensho+blink_opera.com, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Handle percent height children of multicol containers correctly. The render flow thread block that's reparented between the multicol container and its actual children is just an implementation detail, invisible to DOM and CSS. Its height will always be auto, and we need to bypass it. BUG=351657 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169050

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -3 lines)			Patch
A +	LayoutTests/fast/multicol/percent-height.html	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A	LayoutTests/fast/multicol/percent-height-expected.html	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBox.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/197113002/1

6 years, 9 months ago (2014-03-12 18:01:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/197113002/1

6 years, 9 months ago (2014-03-12 18:29:43 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/197113002/1

6 years, 9 months ago (2014-03-12 18:37:24 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/197113002/1

6 years, 9 months ago (2014-03-12 18:41:34 UTC) #6

Message was sent while issue was closed.

Change committed as 169050

Expand Messages | Collapse Messages