Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1971093003: 👽 Fix resource_sizes.py when looking at ChromeModern.apk (Closed)

Created:
4 years, 7 months ago by agrieve
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix resource_sizes.py when looking at ChromeModern.apk Something about ChromeModern.apk triggers a bug in Python's zipfile. It's been fixed already: https://bugs.python.org/issue14315 So this swaps in the fixed version of the broken function. BUG=none Committed: https://crrev.com/83011ed3cfafa49f86906e470d4e0edf8c1e3dd6 Cr-Commit-Position: refs/heads/master@{#393336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M build/android/resource_sizes.py View 2 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/05/12 18:38:12, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:rnephew@chromium.org Not the nicest, ...
4 years, 7 months ago (2016-05-12 18:38:49 UTC) #3
rnephew (Reviews Here)
On 2016/05/12 18:38:49, agrieve wrote: > On 2016/05/12 18:38:12, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
4 years, 7 months ago (2016-05-12 18:42:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971093003/1
4 years, 7 months ago (2016-05-12 18:45:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 19:56:59 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 19:58:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83011ed3cfafa49f86906e470d4e0edf8c1e3dd6
Cr-Commit-Position: refs/heads/master@{#393336}

Powered by Google App Engine
This is Rietveld 408576698