Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 1971033003: ExclusiveAccessBubbleViews: Remove unused code for old style. (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fullscreen-remove-old-theming
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ExclusiveAccessBubbleViews: Remove unused code for old style. We recently made the flag-disabled version work almost the same as the flag-enabled version of the fullscreen bubble. This cleans up all the dead code that is no longer used in either version. BUG=610900 Committed: https://crrev.com/b8fb109d29fa31626e110cbaed516a7b0de77d48 Cr-Commit-Position: refs/heads/master@{#394023}

Patch Set 1 #

Patch Set 2 : Minor comment. #

Patch Set 3 : Remove unused url parameter. #

Patch Set 4 : Rebase. #

Patch Set 5 : Remove unused include. #

Total comments: 2

Patch Set 6 : Inline UpdateForImmersiveState. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -154 lines) Patch
M chrome/browser/ui/views/exclusive_access_bubble_views.h View 1 2 3 4 5 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/exclusive_access_bubble_views.cc View 1 2 3 4 5 19 chunks +14 lines, -139 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Matt Giuca
Follow-up to https://codereview.chromium.org/1972543002/ Thanks!
4 years, 7 months ago (2016-05-16 05:15:53 UTC) #3
msw
lgtm with a nit https://codereview.chromium.org/1971033003/diff/80001/chrome/browser/ui/views/exclusive_access_bubble_views.cc File chrome/browser/ui/views/exclusive_access_bubble_views.cc (right): https://codereview.chromium.org/1971033003/diff/80001/chrome/browser/ui/views/exclusive_access_bubble_views.cc#newcode391 chrome/browser/ui/views/exclusive_access_bubble_views.cc:391: void ExclusiveAccessBubbleViews::UpdateForImmersiveState() { optional nit: ...
4 years, 7 months ago (2016-05-16 17:17:13 UTC) #4
Matt Giuca
https://codereview.chromium.org/1971033003/diff/80001/chrome/browser/ui/views/exclusive_access_bubble_views.cc File chrome/browser/ui/views/exclusive_access_bubble_views.cc (right): https://codereview.chromium.org/1971033003/diff/80001/chrome/browser/ui/views/exclusive_access_bubble_views.cc#newcode391 chrome/browser/ui/views/exclusive_access_bubble_views.cc:391: void ExclusiveAccessBubbleViews::UpdateForImmersiveState() { On 2016/05/16 17:17:13, msw wrote: > ...
4 years, 7 months ago (2016-05-17 00:52:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971033003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971033003/100001
4 years, 7 months ago (2016-05-17 00:53:20 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-17 02:27:46 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 02:28:59 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/b8fb109d29fa31626e110cbaed516a7b0de77d48
Cr-Commit-Position: refs/heads/master@{#394023}

Powered by Google App Engine
This is Rietveld 408576698