Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 1971033002: Call scheduler when we get a save page later request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per FGorski and DougArnett Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index bf447575773bc00e0defe3b16d72bbbdf0695afa..37fa98ccb73c5ef715491808fb0733a3fadd63f2 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -10,18 +10,19 @@
#include "components/offline_pages/background/offliner_factory.h"
#include "components/offline_pages/background/offliner_policy.h"
#include "components/offline_pages/background/save_page_request.h"
+#include "components/offline_pages/background/scheduler.h"
#include "components/offline_pages/offline_page_item.h"
namespace offline_pages {
-RequestCoordinator::RequestCoordinator(std::unique_ptr<OfflinerPolicy> policy,
- std::unique_ptr<OfflinerFactory> factory,
- std::unique_ptr<RequestQueue> queue) {
- // Do setup as needed.
- // TODO(petewil): Assert policy not null.
- policy_ = std::move(policy);
- factory_ = std::move(factory);
- queue_ = std::move(queue);
+RequestCoordinator::RequestCoordinator(
+ std::unique_ptr<OfflinerPolicy> policy,
+ std::unique_ptr<OfflinerFactory> factory,
+ std::unique_ptr<RequestQueue> queue,
+ std::unique_ptr<Scheduler> scheduler)
+ : policy_(std::move(policy)), factory_(std::move(factory)),
+ queue_(std::move(queue)), scheduler_(std::move(scheduler)) {
+ DCHECK(policy_ != nullptr);
}
RequestCoordinator::~RequestCoordinator() {}
@@ -53,7 +54,9 @@ void RequestCoordinator::AddRequestResultCallback(
DVLOG(2) << __FUNCTION__;
// Inform the scheduler that we have an outstanding task.
- // TODO(petewil): implement.
+ // TODO(petewil): Define proper TriggerConditions and set them.
+ Scheduler::TriggerCondition conditions;
+ scheduler_->Schedule(conditions);
}
bool RequestCoordinator::StartProcessing(

Powered by Google App Engine
This is Rietveld 408576698