Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4212)

Unified Diff: chrome/browser/android/offline_pages/request_coordinator_factory.cc

Issue 1971033002: Call scheduler when we get a save page later request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per FGorski and DougArnett Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/request_coordinator_factory.cc
diff --git a/chrome/browser/android/offline_pages/request_coordinator_factory.cc b/chrome/browser/android/offline_pages/request_coordinator_factory.cc
index 645ce5202b09f6fd57eb3cbe88053ddb0fcc9770..4894de2d40ebf09dc8cce1632b51b7366375ccc1 100644
--- a/chrome/browser/android/offline_pages/request_coordinator_factory.cc
+++ b/chrome/browser/android/offline_pages/request_coordinator_factory.cc
@@ -7,6 +7,7 @@
#include <memory>
#include "base/memory/singleton.h"
+#include "chrome/browser/android/offline_pages/background_scheduler_bridge.h"
#include "chrome/browser/android/offline_pages/prerendering_offliner_factory.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
#include "components/offline_pages/background/offliner_factory.h"
@@ -15,6 +16,7 @@
#include "components/offline_pages/background/request_queue.h"
#include "components/offline_pages/background/request_queue_in_memory_store.h"
#include "components/offline_pages/background/request_queue_store.h"
+#include "components/offline_pages/background/scheduler.h"
namespace offline_pages {
@@ -38,15 +40,21 @@ RequestCoordinator* RequestCoordinatorFactory::GetForBrowserContext(
KeyedService* RequestCoordinatorFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());
- std::unique_ptr<OfflinerFactory> prerendererOffliner(
+ std::unique_ptr<OfflinerFactory> prerenderer_offliner(
new PrerenderingOfflinerFactory(context));
std::unique_ptr<RequestQueueInMemoryStore> store(
new RequestQueueInMemoryStore());
std::unique_ptr<RequestQueue> queue(new RequestQueue(std::move(store)));
// TODO(petewil) Add support for server based offliner when it is ready.
- return new RequestCoordinator(
- std::move(policy), std::move(prerendererOffliner), std::move(queue));
+ std::unique_ptr<Scheduler>
+ scheduler(new android::BackgroundSchedulerBridge());
+ // TODO(petewil) Add support for server based offliner when it is ready.
+
+ return new RequestCoordinator(std::move(policy),
+ std::move(prerenderer_offliner),
+ std::move(queue),
+ std::move(scheduler));
}
content::BrowserContext* RequestCoordinatorFactory::GetBrowserContextToUse(

Powered by Google App Engine
This is Rietveld 408576698