Call scheduler when we get a save page later request.

components/offline_pages/background/request_coordinator_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/background/request_coordinator.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 #include "components/offline_pages/background/offliner_factory.h"
 #include "components/offline_pages/background/offliner_policy.h"
 #include "components/offline_pages/background/request_queue.h"
 #include "components/offline_pages/background/request_queue_in_memory_store.h"
 #include "components/offline_pages/background/save_page_request.h"
+#include "components/offline_pages/background/scheduler.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace offline_pages {
 
 namespace {
 // put test constants here
 const GURL kUrl("http://universe.com/everything");
 const ClientId kClientId("bookmark", "42");
 }  // namespace
 
+class SchedulerStub : public Scheduler {
+ public:
+  SchedulerStub() {
+    schedule_called_ = false;

[fgorski, 2016/05/12 14:32:35]

C++ again, use initializer list, please.

[Pete Williamson, 2016/05/12 17:21:19]

Done.

+    unschedule_called_ = false;
+  }
+
+  void Schedule(const TriggerCondition& trigger_condition) override {
+    schedule_called_ = true;
+  }
+
+  // Unschedules the currently scheduled task, if any.
+  void Unschedule() override {
+    unschedule_called_ = true;
+  }
+
+  bool WasScheduleCalled() { return schedule_called_; }

[fgorski, 2016/05/12 14:32:35]

can this be a const method?
Did you consider simple schedule_called()?

[Pete Williamson, 2016/05/12 17:21:19]

Done.

+
+  bool WasUnscheduleCalled() { return unschedule_called_; }

[fgorski, 2016/05/12 14:32:35]

ditto.

[Pete Williamson, 2016/05/12 17:21:19]

Done.

+
+ private:
+  bool schedule_called_;
+  bool unschedule_called_;
+};
+
 class RequestCoordinatorTest
     : public testing::Test {
  public:
   RequestCoordinatorTest();
   ~RequestCoordinatorTest() override;
 
   void SetUp() override;
 
   void PumpLoop();
 
   RequestCoordinator* getCoordinator() {

[fgorski, 2016/05/12 14:32:35]

nit: can you rename it to coordinator() or GetCoordinator()?

[Pete Williamson, 2016/05/12 17:21:18]

Done.

     return coordinator_.get();
   }
 
   // Empty callback function
   void EmptyCallbackFunction() {
   }
 
   // Callback for getting requests.
   void GetRequestsDone(RequestQueue::GetRequestsResult result,
                        const std::vector<SavePageRequest>& requests);
@@ skipping 20 matching lines @@
       task_runner_handle_(task_runner_) {}
 
 RequestCoordinatorTest::~RequestCoordinatorTest() {}
 
 void RequestCoordinatorTest::SetUp() {
   std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());
   std::unique_ptr<OfflinerFactory> factory;
   std::unique_ptr<RequestQueueInMemoryStore>
       store(new RequestQueueInMemoryStore());
   std::unique_ptr<RequestQueue> queue(new RequestQueue(std::move(store)));
+    std::unique_ptr<Scheduler> schedulerStub(new SchedulerStub());

[fgorski, 2016/05/12 14:32:35]

nit: alignment

[dougarnett, 2016/05/12 15:33:33]

scheduler_stub I suppose

[Pete Williamson, 2016/05/12 17:21:18]

Done.

[Pete Williamson, 2016/05/12 17:21:19]

Done.

   coordinator_.reset(new RequestCoordinator(
-      std::move(policy), std::move(factory), std::move(queue)));
+      std::move(policy), std::move(factory), std::move(queue),
+      std::move(schedulerStub)));
 }
 
 
 void RequestCoordinatorTest::PumpLoop() {
   task_runner_->RunUntilIdle();
 }
 
 void RequestCoordinatorTest::GetRequestsDone(
     RequestQueue::GetRequestsResult result,
     const std::vector<SavePageRequest>& requests) {
@@ skipping 18 matching lines @@
                  base::Unretained(this)));
 
   // Wait for callback to finish.
   PumpLoop();
 
   // Check the results are as expected.
   EXPECT_EQ(1UL, last_requests().size());
   EXPECT_EQ(kUrl, last_requests()[0].url());
   EXPECT_EQ(kClientId, last_requests()[0].client_id());
 
-  // TODO(petewil): Expect that the scheduler got notified.
+  // Expect that the scheduler got notified.
+  SchedulerStub* stub = reinterpret_cast<SchedulerStub*>(
+      getCoordinator()->GetSchedulerForTesting());
+  EXPECT_TRUE(stub->WasScheduleCalled());
+

[fgorski, 2016/05/12 14:32:35]

nit: empty lines.

[Pete Williamson, 2016/05/12 17:21:19]

Done.

 }
 
 }  // namespace offline_pages