Call scheduler when we get a save page later request.

components/offline_pages/background/request_coordinator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/background/request_coordinator.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "components/offline_pages/background/offliner_factory.h"
 #include "components/offline_pages/background/offliner_policy.h"
 #include "components/offline_pages/background/save_page_request.h"
+#include "components/offline_pages/background/scheduler.h"
 #include "components/offline_pages/offline_page_item.h"
 
 namespace offline_pages {
 
-RequestCoordinator::RequestCoordinator(std::unique_ptr<OfflinerPolicy> policy,
-                                       std::unique_ptr<OfflinerFactory> factory,
-                                       std::unique_ptr<RequestQueue> queue) {
+RequestCoordinator::RequestCoordinator(
+    std::unique_ptr<OfflinerPolicy> policy,
+    std::unique_ptr<OfflinerFactory> factory,
+    std::unique_ptr<RequestQueue> queue,
+    std::unique_ptr<Scheduler> scheduler) {
   // Do setup as needed.
   // TODO(petewil): Assert policy not null.

[fgorski, 2016/05/12 14:32:35]

can you already do this?

[Pete Williamson, 2016/05/12 17:21:18]

Done.

   policy_ = std::move(policy);
   factory_ = std::move(factory);
   queue_ = std::move(queue);
+  scheduler_ = std::move(scheduler);

[fgorski, 2016/05/12 14:32:35]

C++: move all assignments to the initializer list.

[Pete Williamson, 2016/05/12 17:21:18]

Done.

 }
 
 RequestCoordinator::~RequestCoordinator() {}
 
 bool RequestCoordinator::SavePageLater(
     const GURL& url, const ClientId& client_id) {
   DVLOG(2) << "URL is " << url << " " << __FUNCTION__;
 
   // TODO(petewil): We need a robust scheme for allocating new IDs.
   static int64_t id = 0;
 
   // Build a SavePageRequest.
   // TODO(petewil): Use something like base::Clock to help in testing.
   offline_pages::SavePageRequest request(
       id++, url, client_id, base::Time::Now());
 
   // Put the request on the request queue.
   queue_->AddRequest(request,
                      base::Bind(&RequestCoordinator::AddRequestResultCallback,
                                 AsWeakPtr()));
   // TODO: Do I need to persist the request in case the add fails?
 
+  Scheduler::TriggerCondition conditions;
+  scheduler_->Schedule(conditions);
+
   return true;
 }
 
 void RequestCoordinator::AddRequestResultCallback(
     RequestQueue::AddRequestResult result,
     const SavePageRequest& request) {
   DVLOG(2) << __FUNCTION__;
 
   // Inform the scheduler that we have an outstanding task.

[dougarnett, 2016/05/12 15:33:33]

Here is where it looked like you were intending to call scheduler?

[Pete Williamson, 2016/05/12 17:21:18]

Ah, right, that code merged in from another changelist.  Moved the schedule call
to here as intended.

   // TODO(petewil): implement.
 }
 
 bool RequestCoordinator::StartProcessing(
     const ProcessingDoneCallback& callback) {
   return false;
 }
 
 void RequestCoordinator::StopProcessing() {
 }
 
 }  // namespace offline_pages