Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 197103005: Have XMLHttpRequest.responseXML return an XMLDocument (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Have XMLHttpRequest.responseXML return an XMLDocument Have XMLHttpRequest.responseXML return an XMLDocument instead of a Document when the response is of XML MIME type. This behavior is consistent with Firefox 27 and IE11. R=arv, tkent BUG=350923 TEST=http/tests/xmlhttprequest/responsexml-type.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169080

Patch Set 1 #

Patch Set 2 : Remove unnecessary forward declaration #

Patch Set 3 : Rebaseline additional test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -25 lines) Patch
M LayoutTests/fast/xmlhttprequest/xmlhttprequest-bad-mimetype-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/responsexml-type-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types-expected.txt View 2 chunks +22 lines, -22 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
6 years, 9 months ago (2014-03-12 20:44:43 UTC) #1
arv (Not doing code reviews)
Is there a bug filed on the spec since the spec still says to use ...
6 years, 9 months ago (2014-03-12 21:42:23 UTC) #2
Inactive
On 2014/03/12 21:42:23, arv wrote: > Is there a bug filed on the spec since ...
6 years, 9 months ago (2014-03-12 21:48:46 UTC) #3
arv (Not doing code reviews)
LGTM
6 years, 9 months ago (2014-03-12 21:55:23 UTC) #4
tkent
lgtm
6 years, 9 months ago (2014-03-13 00:55:26 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-13 00:55:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/197103005/40001
6 years, 9 months ago (2014-03-13 00:55:34 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 02:21:47 UTC) #8
Message was sent while issue was closed.
Change committed as 169080

Powered by Google App Engine
This is Rietveld 408576698