Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 197103002: Move most scanner buffer accesses into scanner. (Closed)

Created:
6 years, 9 months ago by dcarney
Modified:
6 years, 9 months ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

Move most scanner buffer accesses into scanner. R=marja@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -114 lines) Patch
M src/parser.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/parser.cc View 4 chunks +4 lines, -26 lines 0 comments Download
M src/preparser.h View 2 chunks +4 lines, -9 lines 0 comments Download
M src/preparser.cc View 4 chunks +11 lines, -22 lines 0 comments Download
M src/scanner.h View 9 chunks +47 lines, -23 lines 0 comments Download
M src/scanner.cc View 6 chunks +66 lines, -22 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
marja
lgtm
6 years, 9 months ago (2014-03-12 10:47:46 UTC) #1
dcarney
6 years, 9 months ago (2014-03-12 14:06:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r19849 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698