Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1971023007: Make the Skia GN build work. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
caryclark
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make the Skia GN build work. On Linux, at least. BUG=pdfium:11 Committed: https://pdfium.googlesource.com/pdfium/+/19ea309f3d46bbd76d4201b4e791b11d736f7834

Patch Set 1 #

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -25 lines) Patch
M skia/BUILD.gn View 5 chunks +3 lines, -18 lines 0 comments Download
M skia/skia_gn_files.gypi View 1 3 chunks +7 lines, -5 lines 0 comments Download
M skia/skia_library.gypi View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia_pdfium.gypi View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Lei Zhang
4 years, 7 months ago (2016-05-13 09:18:52 UTC) #3
caryclark
lgtm
4 years, 7 months ago (2016-05-13 12:47:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971023007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971023007/20001
4 years, 7 months ago (2016-05-13 17:50:44 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 18:24:30 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/19ea309f3d46bbd76d4201b4e791b11d736f...

Powered by Google App Engine
This is Rietveld 408576698