Check for and skip long paths when importing w3c tests.

Check for and skip long paths when importing w3c tests.

BUG=609871
Committed: https://crrev.com/e651182c099f9d0f3c8b106f762736051f15e3be
Cr-Commit-Position: refs/heads/master@{#393679}

[qyearsley, 2016-05-11 22:27:27]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-05-11 22:27:30]

Before this is committed, I'll confirm that update-w3c-deps can be run and it
will skip the troublesome path
("custom-elements/pre-v1/instantiating-custom-elements/extensions-to-document-interface/create-element-interface-type-is-a-type-extension.html")...

https://codereview.chromium.org/1970963002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
(right):

https://codereview.chromium.org/1970963002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:99: 
Can't yet add a test that calls do_import and checks that a file in a fake
filesystem is skipped, because first test_importer has to be changed to use
webkitpy.common.system.filesystem, so that filesystem can be properly mocked
(there's a fixme for this in the code now).

[qyearsley, 2016-05-11 22:36:41]

On 2016/05/11 at 22:27:30, qyearsley wrote:
> Before this is committed, I'll confirm that update-w3c-deps can be run and it
will skip the troublesome path
("custom-elements/pre-v1/instantiating-custom-elements/extensions-to-document-interface/create-element-interface-type-is-a-type-extension.html")...
> 

Just tried it out and it did skip a bunch of long paths. Resulting CL:
https://codereview.chromium.org/1967303002

[Dirk Pranke, 2016-05-12 00:53:24]

https://codereview.chromium.org/1970963002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/1970963002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:94:
MAX_PATH_LENGTH = 110
Please say in the comment (and the error message) where this number comes from.

[qyearsley, 2016-05-13 16:51:20]

https://codereview.chromium.org/1970963002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/1970963002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:94:
MAX_PATH_LENGTH = 110
On 2016/05/12 at 00:53:23, Dirk Pranke wrote:
> Please say in the comment (and the error message) where this number comes
from.

More explanation added now.

[Dirk Pranke, 2016-05-13 18:01:41]

lgtm.

https://codereview.chromium.org/1970963002/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/1970963002/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:355:
_log.warning('%s skipped (longer than %d chars), to avoid hitting Windows max
path length on builders.',
I'd actually include the bug number in the message.

[qyearsley, 2016-05-13 21:45:19]

https://codereview.chromium.org/1970963002/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/1970963002/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:355:
_log.warning('%s skipped (longer than %d chars), to avoid hitting Windows max
path length on builders.',
On 2016/05/13 at 18:01:41, Dirk Pranke wrote:
> I'd actually include the bug number in the message.

Done now.

[qyearsley, 2016-05-13 21:45:23]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 21:46:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970963002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970963002/80001

[commit-bot: I haz the power, 2016-05-13 22:59:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 22:59:18]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-05-13 23:06:34]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-05-13 23:06:34]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1970963002/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2016-05-13 23:07:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970963002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970963002/80001

[commit-bot: I haz the power, 2016-05-13 23:11:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-13 23:13:57]

Description was changed from

==========
Check for and skip long paths when importing w3c tests.

BUG=609871
==========

to

==========
Check for and skip long paths when importing w3c tests.

BUG=609871

Committed: https://crrev.com/e651182c099f9d0f3c8b106f762736051f15e3be
Cr-Commit-Position: refs/heads/master@{#393679}
==========

[commit-bot: I haz the power, 2016-05-13 23:13:57]

Patchset 5 (id:??) landed as
https://crrev.com/e651182c099f9d0f3c8b106f762736051f15e3be
Cr-Commit-Position: refs/heads/master@{#393679}