components/offline_pages/offline_page_storage_manager.h - Issue 1970953002: [Offline Pages] Adding more expiration logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_storage_manager.h

Issue 1970953002: [Offline Pages] Adding more expiration logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@interface

Patch Set: fixing builds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/offline_page_storage_manager.h

diff --git a/components/offline_pages/offline_page_storage_manager.h b/components/offline_pages/offline_page_storage_manager.h

index cf1dc7f6c9f4fb679194b374f91773d34302a0db..91b8f8fb0117834342e901422bb813e90d1a54b7 100644

--- a/components/offline_pages/offline_page_storage_manager.h

+++ b/components/offline_pages/offline_page_storage_manager.h

@@ -74,8 +74,8 @@ class OfflinePageStorageManager {

// Determine if manager should clear pages.

bool ShouldClearPages();

- // Return true if |page| is expired.

- bool IsPageExpired(const OfflinePageItem& page);

+ // Return true if |page| is expired comparing to |now|.

+ bool IsPageExpired(const base::Time& now, const OfflinePageItem& page);

// Not owned.

Client* client_;