Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1970953002: [Offline Pages] Adding more expiration logic. (Closed)

Created:
4 years, 7 months ago by romax
Modified:
4 years, 7 months ago
Reviewers:
fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@interface
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Adding more expiration logic. BUG=609357 Committed: https://crrev.com/84146c7d410b92010d8599b7fea3f9de345dfdbc Cr-Commit-Position: refs/heads/master@{#393397}

Patch Set 1 #

Patch Set 2 : Fix build after rebasing interface changes. #

Patch Set 3 : fixing builds. #

Total comments: 17

Patch Set 4 : Comments from Filip. #

Total comments: 2

Patch Set 5 : More comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -33 lines) Patch
M components/offline_pages/offline_page_storage_manager.h View 1 2 3 4 4 chunks +12 lines, -2 lines 0 comments Download
M components/offline_pages/offline_page_storage_manager.cc View 1 2 3 4 4 chunks +46 lines, -5 lines 0 comments Download
M components/offline_pages/offline_page_storage_manager_unittest.cc View 1 2 3 5 chunks +115 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
romax
PTAL
4 years, 7 months ago (2016-05-12 00:07:09 UTC) #2
fgorski
https://codereview.chromium.org/1970953002/diff/40001/components/offline_pages/offline_page_storage_manager.cc File components/offline_pages/offline_page_storage_manager.cc (right): https://codereview.chromium.org/1970953002/diff/40001/components/offline_pages/offline_page_storage_manager.cc#newcode51 components/offline_pages/offline_page_storage_manager.cc:51: base::Time now = base::Time::Now(); use base::Clock for tracking time. ...
4 years, 7 months ago (2016-05-12 14:49:32 UTC) #3
romax
Addressing comments from Filip. Not changing from map to vector though... https://codereview.chromium.org/1970953002/diff/40001/components/offline_pages/offline_page_storage_manager.cc File components/offline_pages/offline_page_storage_manager.cc (right): ...
4 years, 7 months ago (2016-05-12 22:20:04 UTC) #4
fgorski
lgtm after comment addressed. https://codereview.chromium.org/1970953002/diff/40001/components/offline_pages/offline_page_storage_manager_unittest.cc File components/offline_pages/offline_page_storage_manager_unittest.cc (right): https://codereview.chromium.org/1970953002/diff/40001/components/offline_pages/offline_page_storage_manager_unittest.cc#newcode160 components/offline_pages/offline_page_storage_manager_unittest.cc:160: {{kBookmarkNamespace, 1, 1}, {kLastNNamespace, 1, ...
4 years, 7 months ago (2016-05-12 22:34:25 UTC) #5
romax
more comments addressed and checking in. https://codereview.chromium.org/1970953002/diff/60001/components/offline_pages/offline_page_storage_manager.h File components/offline_pages/offline_page_storage_manager.h (right): https://codereview.chromium.org/1970953002/diff/60001/components/offline_pages/offline_page_storage_manager.h#newcode87 components/offline_pages/offline_page_storage_manager.h:87: void SetClockForTesting(std::unique_ptr<base::Clock> clock); ...
4 years, 7 months ago (2016-05-12 23:31:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970953002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970953002/80001
4 years, 7 months ago (2016-05-12 23:31:42 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-12 23:35:05 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 23:37:26 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/84146c7d410b92010d8599b7fea3f9de345dfdbc
Cr-Commit-Position: refs/heads/master@{#393397}

Powered by Google App Engine
This is Rietveld 408576698