Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1970923002: [MD settings] update i18n replacements in bluetooth settings (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] i18n replacements in bluetooth settings This CL has mechanical changes to convert i18n-content replacement to $i18n replacements in the bluetooth settings. BUG=611188 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -34 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_add_device_dialog.html View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html View 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_pair_device_dialog.html View 2 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
dschuyler
If this patch is inconvenient (due to your working on the bluetooth layout / merge ...
4 years, 7 months ago (2016-05-11 21:39:52 UTC) #4
Dan Beam
4 years, 7 months ago (2016-05-11 23:56:50 UTC) #5 
doing this was already required when I switched things to be inside dom-ifs (so
it should basically already be done)

Powered by Google App Engine
This is Rietveld 408576698