chrome/test/data/ssl/page_with_unsafe_contents.html - Issue 1970893002: Fix checking of iframe contents in SSLUITest.TestUnsafeContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/ssl/page_with_unsafe_contents.html

Issue 1970893002: Fix checking of iframe contents in SSLUITest.TestUnsafeContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: estark comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/ssl/page_with_unsafe_contents.html

diff --git a/chrome/test/data/ssl/page_with_unsafe_contents.html b/chrome/test/data/ssl/page_with_unsafe_contents.html

index d8910a1f300522afe6ae706c35e49cd5ffa879bd..dc655debfeed5ef720e430d852e4bdde0db2e59c 100644

--- a/chrome/test/data/ssl/page_with_unsafe_contents.html

+++ b/chrome/test/data/ssl/page_with_unsafe_contents.html

@@ -20,7 +20,7 @@ This page contains an image which is served over an insecure HTTPS connection...

And an IFrame served over insecure HTTPS...<br>

-<iframe id="bad_iframe" src="https://REPLACE_WITH_HOST_AND_PORT/ssl/bad_iframe.html"/>

+<iframe id="bad_iframe" src="https://REPLACE_WITH_HOST_AND_PORT/ssl/bad_iframe.html?open_popup=1"/>

And even worse, some JavaScript served over insecure HTTPS...<br>

« no previous file with comments | « chrome/test/data/ssl/bad_iframe.html ('k') | no next file » | no next file with comments »