appengine/logdog/coordinator/endpoints/logs/list.go - Issue 1970823005: LogDog: Add prefix registration endpoint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/logdog/coordinator/endpoints/logs/list.go

Issue 1970823005: LogDog: Add prefix registration endpoint. (Closed) Base URL: https://github.com/luci/luci-go@logdog-project-archivist-useconfig

Patch Set: Updated patchset dependency Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/logdog/coordinator/endpoints/logs/list.go

diff --git a/appengine/logdog/coordinator/endpoints/logs/list.go b/appengine/logdog/coordinator/endpoints/logs/list.go

index e40b0a3f72ca16fc0284104ff14eb831fa5ab73c..131f8c54388f26330ea0b2905789a181ee62ca1b 100644

--- a/appengine/logdog/coordinator/endpoints/logs/list.go

+++ b/appengine/logdog/coordinator/endpoints/logs/list.go

@@ -91,9 +91,10 @@ func (s *server) List(c context.Context, req *logdog.ListRequest) (*logdog.ListR

// a list of streams to load.

if req.State && l.Project != "" {

c := c

- if err := coordinator.WithProjectNamespace(&c, l.Project); err != nil {

- // This should work, since the list would have rejected the namespace if

- // the user was not a member, so a failure here is an internal error.

+ if err := coordinator.WithProjectNamespace(&c, l.Project, coordinator.NamespaceAccessREAD); err != nil {

+ // This should work, since the decorated service would have rejected the

+ // namespace if the user was not a member, so a failure here is an

+ // internal error.

log.Fields{

log.ErrorKey: err,

"project": l.Project,