appengine/cmd/logdog_coordinator/register/module-register.yaml - Issue 1970823005: LogDog: Add prefix registration endpoint.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/cmd/logdog_coordinator/register/module-register.yaml

Issue 1970823005: LogDog: Add prefix registration endpoint. (Closed) Base URL: https://github.com/luci/luci-go@logdog-project-archivist-useconfig

Patch Set: Updated patchset dependency Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« appengine/cmd/logdog_coordinator/register/doc.go ('K') | « appengine/cmd/logdog_coordinator/register/main.go ('k') | appengine/cmd/logdog_coordinator/vmuser/main.go » ('j') | appengine/logdog/coordinator/context.go » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 module: services	5 module: register
	nodir 2016/05/19 16:43:17 I am not sure why you have to have a whole another I am not sure why you have to have a whole another appengine module for one function. Why not same module? Why not same service? looks unnecessarily complicated to me dnj (Google) 2016/05/19 22:52:04 Well, currently I have the following modules: "bac Show quoted text On 2016/05/19 16:43:17, nodir wrote: > I am not sure why you have to have a whole another appengine module for one > function. Why not same module? Why not same service? looks unnecessarily > complicated to me Well, currently I have the following modules: "backend": Specifically backend services, admin/cron only. "vmuser": A managed VM instance for user access. "service": A classic GAE instance for only service access. My thought was that all of these share ACL sets, so I'd create another separate module space for the new ACL set (write). However, I guess I had a "one module per service" mentality. I think I will put this into the "service" endpoint and just have it export two services.
6 runtime: go	6 runtime: go

7 api_version: go1	7 api_version: go1

8	8

9 handlers:	9 handlers:

10 - url: /.*	10 - url: /.*

11 script: _go_app	11 script: _go_app

12 secure: always	12 secure: always

OLD	NEW